Add explicit to StringTokenizer ctor and move more to the initializer list in ctor #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, merged as commit f825b41
|
|
@schwehr for some reason Appveyor is now reporting a failure after my commit, can you see why ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just minor cleanup. A little background on why I made this patch:
I am working on a fuzzer for WktReader and ran into ASAN detecting leak troubles very quickly with things like
MULTIPOLYGON (. In trying to work on WktReader, I wanted to make sure I understand StringTokenizer. In writing a test, I was passing""to the constructor, which created a temp object which was destroyed after the ctor resulting in a use-after-free in my test.And might as well move everything to the constructor list that I can while I'm looking at the StringTokenizer ctor.
geos/tests/io/StringTokenizer_test.cc:
schwehr/gdal-autotest2@dbe3d75