Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaks: cleanup if failing to parse the WKT MultiLineString, MultiPolygon, and GeometryCollection string. (#830) #84

Closed
wants to merge 3 commits into from

Conversation

schwehr
Copy link
Member

@schwehr schwehr commented Apr 12, 2017

Wrap parsing in try blocks.
Catch any exception, cleanup, and rethrow.

Proposed solution for https://trac.osgeo.org/geos/ticket/830

…Polygon, and GeometryCollection string. (libgeos#830)

Wrap parsing in try blocks.
Catch any exception, cleanup, and rethrow.
@strk
Copy link
Member

strk commented Apr 13, 2017 via email

schwehr added a commit to schwehr/gdal-autotest2 that referenced this pull request Apr 13, 2017
@schwehr
Copy link
Member Author

schwehr commented Apr 13, 2017

My tests are here. Sorry they are not done as a patch for libgeos.

schwehr/gdal-autotest2@92f23e2

Found with LLVM ASAN fuzzer: schwehr/gdal-autotest2@0900947

schwehr added a commit to schwehr/gdal-autotest2 that referenced this pull request Apr 13, 2017
Found memory leak with "MULTIPOLYGON(":

https://trac.osgeo.org/geos/ticket/830

Fix for libgeos: libgeos/geos#84
@strk
Copy link
Member

strk commented Apr 14, 2017 via email

@schwehr
Copy link
Member Author

schwehr commented Apr 15, 2017

Please take a look at the tests.

@strk
Copy link
Member

strk commented Apr 15, 2017

Pushed as 8447747, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants