-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change MultiPoint WKT to use parentheses in sub-members #903
Conversation
|
I wonder how many downstream projects have tests against the WKT output of MULTIPOINT. |
|
Possibly a few, for instance I'll try shapely later. Another strategy is to modify WKTWriter to enable an option, keeping the default to use old behaviour. |
I think we have to note this as a breaking change and move on. It's more important to be standards-compliant. |
|
It's good to update the unit tests that aren't specifically checking this behaviour. But are there still tests for |
Yes, and I intentionally left a few test cases with the previous form. The only exception that I'm aware of #902 which will be closed as "not planned". |
WKB Multipoint formatting update, see libgeos/geos#903
Also see libgeos/geos#903 Convert to consistent format before comparison, see: libgeos/geos@4acb5e0
This is a potentially breaking change that switches the WKT output of MultiPoint from:
to
This aligns with JTS' outputs of MultiPoint and with ISO/OGC specs.
See also postgis/postgis#682 which was implemented for PostGIS 3.3