Change WKTWriter default output dimension to 4 and trim to 'on'

[mwtoews]

This potentially breaking change with the WKTWriter is to use output dimension 4 and trim 'on'.

For example, POINT Z (1.1 2.2 3.3) output using defaults are:

• Current: POINT (1.1000000000000001 2.2000000000000002)
• Proposed: POINT Z (1.1 2.2 3.3)

Other details:

• From the C++ API, both toText() and toString() will also use the new defaults; add tests/unit/geom/Geometry/toTextTest.cpp for this coverage
• Deprecated GEOSGeomToWKT (and GEOSGeomToWKT_r) should keep the previous defaults showing untrimmed 2D outputs, which is checked with tests/unit/capi/GEOSGeomToWKTTest.cpp

[pramsey]

I've brought this in, hopefully downstream sees not too much test churn.

[BuonOmo]

@pramsey shouldn't these kind of changes be part of majors? Asking because this is breaking the RGeo ruby gem based on GEOS, and being maintainer I'd like to know when to expect these kind of breaking changes!

[pramsey]

I would tend to think not? We have behaviour changes every release, but what I've internalize as "breaking" change has been C API change. Once you cannot plunk a GEOS binary on top of another one. Things like "what outputs are produced" are in flux (behaviour of concave hull, etc) and there's really no way to work on the library without that happening. I sympathize with your point of view, but I don't know if I quite agree.

[BuonOmo]

Hm okay this make sense for sure. I'll subscribe to the gh releases then. In case there is some kind of information given before releasing, my email is buonomo dot ulysse at gmail dot com!

[pramsey]

The ideal place to keep your finger on the pulse of GEOS is the mailing list, https://lists.osgeo.org/listinfo/geos-devel (yes, we are very old). There you will see pre-release announcements, etc, and other downstream packagers for things like Python, R, Swift, etc.