fixes for MSVC compilation #76

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@aescande

missing GEOS_DLL and USE_MATH_DEFINES (M_PI is not standard C++)

tests/unit/capi/GEOSDistanceTest.cpp
@@ -9,6 +9,9 @@
#include <cstdio>
#include <cstdlib>
#include <memory>
+#if defined(_MSC_VER)
+# define _USE_MATH_DEFINES
+#endif
#include <math.h>
@strk
strk Jan 10, 2017 Member

In other files we have this block:

#ifndef M_PI
#define M_PI        3.14159265358979323846
#endif

Please use the same (BTW, one such block is in platform.h.vc)

@aescande

Update to take into account the M_PI remark

@strk
Member
strk commented Jan 12, 2017

Thanks, committed
r4325 = bd1b03e (refs/remotes/trunk)

@strk strk closed this Jan 12, 2017
@strk strk added a commit that referenced this pull request Jan 12, 2017
@strk strk Missing GEOS_DLL and USE_MATH_DEFINES for MSVC compilation
Patch by Escande Adrien <adrien.escande@gmail.com> via
#76

git-svn-id: http://svn.osgeo.org/geos/trunk@4325 5242fede-7e19-0410-aef8-94bd7d2200fb
bd1b03e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment