Could not determine kind of name for C.GIT_BLAME_IGNORE_WHITESPACE #711
Comments
|
per https://github.com/libgit2/git2go#which-go-version-to-use it should be |
|
Aah, I am terribly sorry for not taking a look at that earlier. Thanks for your work, anyhow! :) |
no worries :) |
lhchavez
added a commit
to lhchavez/git2go
that referenced
this issue
Dec 13, 2020
This change renames the build files so they come lexicographically before any source files. This makes the compile errors (due to mismatched libgit2 versions) easier to understand, since the `Build_*.go` files will be tried before the rest, and the `#error` in those files will kick in, leading to a much better experience. This unfortunately goes a bit against the defacto standard of using only lowercase characters in filenames, but the better developer experience (and better self-diagnosis when things go wrong instead of having to open a new issue) is worth the deviation. Fixes: libgit2#711 Fixes: libgit2#617
Merged
lhchavez
added a commit
that referenced
this issue
Dec 13, 2020
This change renames the build files so they come lexicographically before any source files. This makes the compile errors (due to mismatched libgit2 versions) easier to understand, since the `Build_*.go` files will be tried before the rest, and the `#error` in those files will kick in, leading to a much better experience. This unfortunately goes a bit against the defacto standard of using only lowercase characters in filenames, but the better developer experience (and better self-diagnosis when things go wrong instead of having to open a new issue) is worth the deviation. Fixes: #711 Fixes: #617
github-actions bot
pushed a commit
that referenced
this issue
Dec 13, 2020
This change renames the build files so they come lexicographically before any source files. This makes the compile errors (due to mismatched libgit2 versions) easier to understand, since the `Build_*.go` files will be tried before the rest, and the `#error` in those files will kick in, leading to a much better experience. This unfortunately goes a bit against the defacto standard of using only lowercase characters in filenames, but the better developer experience (and better self-diagnosis when things go wrong instead of having to open a new issue) is worth the deviation. Fixes: #711 Fixes: #617 (cherry picked from commit 4b2ac7c)
github-actions bot
pushed a commit
that referenced
this issue
Dec 13, 2020
This change renames the build files so they come lexicographically before any source files. This makes the compile errors (due to mismatched libgit2 versions) easier to understand, since the `Build_*.go` files will be tried before the rest, and the `#error` in those files will kick in, leading to a much better experience. This unfortunately goes a bit against the defacto standard of using only lowercase characters in filenames, but the better developer experience (and better self-diagnosis when things go wrong instead of having to open a new issue) is worth the deviation. Fixes: #711 Fixes: #617 (cherry picked from commit 4b2ac7c)
github-actions bot
pushed a commit
that referenced
this issue
Dec 13, 2020
This change renames the build files so they come lexicographically before any source files. This makes the compile errors (due to mismatched libgit2 versions) easier to understand, since the `Build_*.go` files will be tried before the rest, and the `#error` in those files will kick in, leading to a much better experience. This unfortunately goes a bit against the defacto standard of using only lowercase characters in filenames, but the better developer experience (and better self-diagnosis when things go wrong instead of having to open a new issue) is worth the deviation. Fixes: #711 Fixes: #617 (cherry picked from commit 4b2ac7c)
This was referenced Dec 13, 2020
lhchavez
added a commit
that referenced
this issue
Dec 13, 2020
This change renames the build files so they come lexicographically before any source files. This makes the compile errors (due to mismatched libgit2 versions) easier to understand, since the `Build_*.go` files will be tried before the rest, and the `#error` in those files will kick in, leading to a much better experience. This unfortunately goes a bit against the defacto standard of using only lowercase characters in filenames, but the better developer experience (and better self-diagnosis when things go wrong instead of having to open a new issue) is worth the deviation. Fixes: #711 Fixes: #617 (cherry picked from commit 4b2ac7c) Co-authored-by: lhchavez <lhchavez@lhchavez.com>
lhchavez
added a commit
that referenced
this issue
Dec 13, 2020
This change renames the build files so they come lexicographically before any source files. This makes the compile errors (due to mismatched libgit2 versions) easier to understand, since the `Build_*.go` files will be tried before the rest, and the `#error` in those files will kick in, leading to a much better experience. This unfortunately goes a bit against the defacto standard of using only lowercase characters in filenames, but the better developer experience (and better self-diagnosis when things go wrong instead of having to open a new issue) is worth the deviation. Fixes: #711 Fixes: #617 (cherry picked from commit 4b2ac7c) Co-authored-by: lhchavez <lhchavez@lhchavez.com>
lhchavez
added a commit
that referenced
this issue
Dec 13, 2020
This change renames the build files so they come lexicographically before any source files. This makes the compile errors (due to mismatched libgit2 versions) easier to understand, since the `Build_*.go` files will be tried before the rest, and the `#error` in those files will kick in, leading to a much better experience. This unfortunately goes a bit against the defacto standard of using only lowercase characters in filenames, but the better developer experience (and better self-diagnosis when things go wrong instead of having to open a new issue) is worth the deviation. Fixes: #711 Fixes: #617 (cherry picked from commit 4b2ac7c) Co-authored-by: lhchavez <lhchavez@lhchavez.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey,
Whilst building git2go v31.4.3 with libgit2 v1.0.1, I get a build failure with the following error:
src/gopkg.in/libgit2/git2go.v31/blame.go:51:54: could not determine kind of name for C.GIT_BLAME_IGNORE_WHITESPACEI am not sure what's wrong, any ideas?
The text was updated successfully, but these errors were encountered: