Permalink
Switch branches/tags
Commits on Jan 19, 2018
  1. Merge pull request #4481 from pks-t/pks/tests-online-clone-url-memleak

    carlosmn committed Jan 19, 2018
    tests: online::clone: fix memory leak due to not freeing URL
Commits on Jan 18, 2018
  1. tests: online::clone: fix memory leak due to not freeing URL

    pks-t committed Jan 18, 2018
Commits on Jan 17, 2018
  1. Merge pull request #4451 from libgit2/charliesome/trailer-info

    brianmario committed Jan 17, 2018
    Implement message trailer parsing API
  2. rename find_trailer to extract_trailer_block

    brianmario committed Jan 17, 2018
  3. Merge pull request #4477 from pks-t/pks/memleaks

    carlosmn committed Jan 17, 2018
    Memory leaks
  4. update code docs

    brianmario committed Jan 17, 2018
  5. just use git_message_trailer in tests

    brianmario committed Jan 17, 2018
  6. try and fix windows build

    brianmario committed Jan 17, 2018
  7. Change trailer API to return a simple array

    brianmario committed Jan 16, 2018
Commits on Jan 12, 2018
  1. tests: refs::iterator: fix memory leak due to ref names not being free'd

    pks-t committed Jan 12, 2018
    The test refs::iterator::foreach_name iterates through every reference
    and copies its name into a local vector. While the test makes sure to
    free the vector afterwards, the copied reference names are not being
    free'd. Fix that.
  2. refs: document need to free refs in foreach-callback

    pks-t committed Jan 12, 2018
    References passed to the callback function of `git_reference_foreach`
    are expected to be owned by the callback. As such, they are never being
    freed by `git_reference_foreach`, but will have to be freed by the
    caller. This small detail is never mentioned in the function's
    documentation, though, making it easy to get wrong. Document this to
    make it discoverable.
  3. transports: local: fix memory leak in reference walk

    pks-t committed Jan 12, 2018
    Upon downloading the pack file, the local transport will iterate through
    every reference using `git_reference_foreach`. The function is a bit
    tricky though in that it requires the passed callback to free the
    references, which does not currently happen.
    
    Fix the memory leak by freeing all passed references in the callback.
  4. tests: network::fetchlocal: let cleanup function handle sandbox cleanup

    pks-t committed Jan 12, 2018
    Two tests in network::fetchlocal explicitly set a cleanup function to
    free and remove the created sandbox repositories. This is not necessary,
    though, as the cleanup function executed after each test already takes
    care of cleaning up after them. Remove the code to avoid needless code
    duplication.
Commits on Jan 11, 2018
  1. Merge remote-tracking branch 'origin/master' into charliesome/trailer…

    brianmario committed Jan 11, 2018
    …-info
Commits on Jan 10, 2018
  1. Merge pull request #4472 from libgit2/ethomson/libgit2deps_azure

    carlosmn committed Jan 10, 2018
    travis: fetch trusty dependencies from Bintray
  2. travis: we use bintray's own key for signing

    carlosmn committed Jan 10, 2018
    The VM on Travis apparently will still proceed, but it's good practice.
  3. travis: fetch trusty dependencies from bintray

    ethomson committed Jan 10, 2018
    The trusty dependencies are now hosted on Bintray.
  4. Merge pull request #4471 from libgit2/cmn/cmake-feature-302

    pks-t committed Jan 10, 2018
    cmake: use a FEATURE_SUMMARY call compatible with 3.0.2
  5. cmake: use a FEATURE_SUMMARY call compatible with 3.0.2

    carlosmn committed Jan 10, 2018
    When we print features, we make an effort to support all the way back to
    pre-3.0. However, in the code for versions from 3 onward we call
    `FEATURE_SUMMARY` with multiple kinds of elements to print in the same line.
    This is only supported in CMake 3.1 and later, making the rather popular CMake
    3.0.2 unable to build the library.
    
    Use a single kind of element per invocation. This means we need to provide a
    "description" text, which CMake provides for us if provide multiple kinds of
    elements.
Commits on Jan 8, 2018
  1. Merge pull request #4468 from libgit2/cmn/openssl-pc

    carlosmn committed Jan 8, 2018
    Make sure to include 'openssl' as a dep when building statically with SHA1DC
  2. cmake: add openssl to the private deps list when it's the TLS impleme…

    carlosmn committed Jan 8, 2018
    …ntation
    
    We might want OpenSSL to be the implementation for SHA-1 and/or TLS. If we only
    want it for TLS (e.g. we're building with the collision-detecting SHA-1
    implementation) then we did not indicate this to the systems including us a
    static library.
    
    Add OpenSSL to the list also during the TLS decision to make sure we say we
    should link to it if we use it for TLS.
  3. cmake: treat LIBGIT2_PC_REQUIRES as a list

    carlosmn committed Jan 8, 2018
    It is indeed a list of dependencies for those which include the static archive.
    This is in preparation for adding two possible places where we might add openssl
    as a dependency.
Commits on Jan 7, 2018
  1. Merge pull request #4467 from libgit2/cmn/static-archive-later

    carlosmn committed Jan 7, 2018
    cmake: move the rule to find static archives close to building clar
  2. cmake: move the rule to find static archives close to building clar

    carlosmn committed Jan 7, 2018
    If we're building static libraries, we want to use that for building our clar
    binary. This is done in 4955125 (2017-09-22; cmake: use static dependencies
    when building static libgit2) but that commit included the rule too early,
    making it affect the search for iconv, meaning we did not find it when we were
    building a static libgit2.
    
    Move the rule to just before building clar, after we've included the rules for
    building the library itself. This lets us find and link to the dynamic libiconv.
Commits on Jan 5, 2018
  1. Merge pull request #4398 from pks-t/pks/generic-sha1

    ethomson committed Jan 5, 2018
    cmake: allow explicitly choosing SHA1 backend
  2. switch back to braced array initializers

    brianmario committed Jan 4, 2018
Commits on Jan 4, 2018
  1. cmake: allow explicitly choosing SHA1 backend

    pks-t committed Dec 5, 2017
    Right now, if SHA1DC is disabled, the SHA1 backend is mostly chosen
    based on which system libgit2 is being compiled on and which libraries
    have been found. To give developers and distributions more choice,
    enable them to request specific backends by passing in a
    `-DSHA1_BACKEND=<BACKEND>` option instead. This completely replaces the
    previous auto-selection.
  2. cmake: default to using SHA1DC

    pks-t committed Dec 5, 2017
    Upstream git.git has changed their default SHA1 implementation to the
    collision-detection algorithm SHA1DC in commit e6b07da27 (Makefile: make
    DC_SHA1 the default, 2017-03-17). To match upstream, align ourselves and
    switch over to SHA1DC by default.
  3. make separators const a macro as well

    brianmario committed Jan 4, 2018
  4. Don't use newer C syntax for declaration in tests

    brianmario committed Jan 4, 2018
Commits on Jan 3, 2018
  1. Merge pull request #4257 from pks-t/pks/stale-test

    ethomson committed Jan 3, 2018
    Execute stale tests
  2. Merge pull request #4437 from pks-t/pks/openssl-hash-errors

    ethomson committed Jan 3, 2018
    hash: openssl: check return values of SHA1_* functions
  3. Merge pull request #4462 from pks-t/pks/diff-generated-excessive-stats

    ethomson committed Jan 3, 2018
    diff_generate: avoid excessive stats of .gitattribute files