New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make packfile_unpack_compressed a private API #3573

Merged
merged 1 commit into from Jan 16, 2016

Conversation

Projects
None yet
2 participants
@pmq20
Contributor

pmq20 commented Jan 12, 2016

packfile_unpack_compressed has already been covered in pack.h

@carlosmn

This comment has been minimized.

Member

carlosmn commented Jan 12, 2016

Then it should be removed from pack.h since it's not a function that should be used outside of pack.c.

@pmq20 pmq20 force-pushed the pmq20:master-12jan16 branch from 11a14d1 to b644e22 Jan 13, 2016

@pmq20 pmq20 changed the title from Remove a unnecessary declaration to Make packfile_unpack_compressed a private API Jan 13, 2016

@pmq20

This comment has been minimized.

Contributor

pmq20 commented Jan 13, 2016

@carlosmn Thanks for reviewing. Changed according to your advice.

carlosmn added a commit that referenced this pull request Jan 16, 2016

Merge pull request #3573 from pmq20/master-12jan16
Make packfile_unpack_compressed a private API

@carlosmn carlosmn merged commit 0f9d154 into libgit2:master Jan 16, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment