Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Revwalk merge base #581
I've moved the main list over to a priority queue. I've left the results list as a
Come to think of it, the ordered insertion in the main loop isn't necessary, as we order them at the end, perhaps even counterproductive.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
On Sat, Mar 03, 2012 at 06:19:39PM -0800, Carlos Martín Nieto wrote:
Yeah, that one is probably less of a big deal.
In the results list, I assume you mean, not in the working list. It does
On Sat, 2012-03-03 at 18:56 -0800, Jeff King wrote:
Yeah, I meant in the results list. In the case that there are several
If you check git.git's commit.c::merge_bases_many() you'll see I
I wrote it because the tests were passing on Windows (and I was willing to add as little code as possible). However I wasn't able to figure a use case when a missing workdir would be valid.
If the tests fail on *nix (p_realpath?) maybe should we add a