Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proxy configuration #6026

Merged
merged 7 commits into from Sep 2, 2021
Merged

Update proxy configuration #6026

merged 7 commits into from Sep 2, 2021

Conversation

ethomson
Copy link
Member

@ethomson ethomson commented Sep 2, 2021

  • Include NO_PROXY support from Add NO_PROXY env support #5796
  • Support http.<url>.proxy configuration options
  • Support empty configuration option to override less specific proxy settings in environment or configuration

Fixes #4164

sathieu and others added 6 commits Sep 2, 2021
@sathieu @ethomson
Add NO_PROXY env support
e5a3277 
Item 2 of 3 from #4164

Signed-off-by: Mathieu Parent <math.parent@gmail.com>
@ethomson
util: introduce git__strlcmp
1196de4 
Introduce a utility function that compares a NUL terminated string to a
possibly not-NUL terminated string with length.  This is similar to
`strncmp` but with an added check to ensure that the lengths match (not
just the `size` portion of the two strings).
@ethomson
tests: create the network::url test hierarcy
3680f0b
@ethomson
url: introduce git_net_url_matches_pattern
e5ba0a3 
Provide a method to determine if a given URL matches a host:port pattern
like the ones found in `NO_PROXY` environment variables.
@ethomson
url: introduce git_net_url_matches_pattern_list
9e98e44 
Provide a utility method on a url to determine if it matches any pattern
in a comma-separated list, similar to what one would find in `NO_PROXY`
environment variables.
@ethomson
url: introduce git_net_url_dup
f89dc91
@ethomson ethomson force-pushed the ethomson/proxy branch 2 times, most recently from 022f6c7 to 25bec84 Compare Sep 2, 2021
@ethomson
remote: refactor proxy detection
3c0f14c 
Update the proxy detection for a remote.

1. Honor `http.<url>.proxy` syntax for a remote's direct URL and
   parent URLs.
2. Honor an empty configuration URL to override a proxy configuration.

Add tests to ensure that configuration specificity is honored.
@ethomson ethomson merged commit 002b2ff into main Sep 2, 2021
22 checks passed
@ethomson ethomson deleted the ethomson/proxy branch Sep 2, 2021
@ethomson ethomson mentioned this pull request Sep 2, 2021
Closed
@jeroen jeroen mentioned this pull request Sep 7, 2021
Open
@sathieu sathieu mentioned this pull request Sep 14, 2021
Merged
@racdev racdev mentioned this pull request Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle less common proxy configuration options
2 participants
@ethomson @sathieu