Look at all the code I killed!
@nulltoken, @arrbee can you double check this?
windows: Properly expand all environment variables
This pull request passes (merged 349fb6d into 5f60fd0).
Looks good to me. I'm glad you were able to unify the two functions - really makes it much cleaner. ✨
I don't know if the loss of the HOME environment variable for Win users will matter to anyone. Presumably not.
The tests-clar/core/env.c test is a little strange now, since it is written around munging the HOME environment variable, although by luck it always munges USERPROFILE, too, so it still passes with this new version of the code.
Can you fixup the test so it makes a tad more sense? Push here and I'll merge. 💋
Okay, I've got the tests fixed. Let me try it out on Windows...
Clean up system file finding tests on Win32
This pull request passes (merged 9cde607 into 5f60fd0).