Remove optional parameters from IRepository

Fix #779

Author: JPaulDuncan

LibGit2Sharp/IRepository.cs

@@ -81,7 +81,7 @@ public interface IRepository : IDisposable
         /// <param name="options"><see cref="CheckoutOptions"/> controlling checkout behavior.</param>
         /// <param name="signature">Identity for use when updating the reflog.</param>
         /// <returns>The <see cref="Branch"/> that was checked out.</returns>
-        Branch Checkout(Branch branch, CheckoutOptions options, Signature signature = null);
+        Branch Checkout(Branch branch, CheckoutOptions options, Signature signature);
 
         /// <summary>
         /// Checkout the specified branch, reference or SHA.
@@ -94,7 +94,7 @@ public interface IRepository : IDisposable
         /// <param name="options"><see cref="CheckoutOptions"/> controlling checkout behavior.</param>
         /// <param name="signature">Identity for use when updating the reflog.</param>
         /// <returns>The <see cref="Branch"/> that was checked out.</returns>
-        Branch Checkout(string committishOrBranchSpec, CheckoutOptions options, Signature signature = null);
+        Branch Checkout(string committishOrBranchSpec, CheckoutOptions options, Signature signature);
 
         /// <summary>
         /// Checkout the specified <see cref="LibGit2Sharp.Commit"/>.
@@ -106,7 +106,7 @@ public interface IRepository : IDisposable
         /// <param name="options"><see cref="CheckoutOptions"/> controlling checkout behavior.</param>
         /// <param name="signature">Identity for use when updating the reflog.</param>
         /// <returns>The <see cref="Branch"/> that was checked out.</returns>
-        Branch Checkout(Commit commit, CheckoutOptions options, Signature signature = null);
+        Branch Checkout(Commit commit, CheckoutOptions options, Signature signature);
 
         /// <summary>
         /// Updates specifed paths in the index and working directory with the versions from the specified branch, reference, or SHA.
@@ -117,7 +117,7 @@ public interface IRepository : IDisposable
         /// <param name = "committishOrBranchSpec">A revparse spec for the commit or branch to checkout paths from.</param>
         /// <param name="paths">The paths to checkout.</param>
         /// <param name="checkoutOptions">Collection of parameters controlling checkout behavior.</param>
-        void CheckoutPaths(string committishOrBranchSpec, IEnumerable<string> paths, CheckoutOptions checkoutOptions = null);
+        void CheckoutPaths(string committishOrBranchSpec, IEnumerable<string> paths, CheckoutOptions checkoutOptions);
 
         /// <summary>
         /// Try to lookup an object by its <see cref="ObjectId"/>. If no matching object is found, null will be returned.
@@ -159,7 +159,7 @@ public interface IRepository : IDisposable
         /// <param name="committer">The <see cref="Signature"/> of who added the change to the repository.</param>
         /// <param name="options">The <see cref="CommitOptions"/> that specify the commit behavior.</param>
         /// <returns>The generated <see cref="LibGit2Sharp.Commit"/>.</returns>
-        Commit Commit(string message, Signature author, Signature committer, CommitOptions options = null);
+        Commit Commit(string message, Signature author, Signature committer, CommitOptions options);
 
         /// <summary>
         /// Sets the current <see cref="Head"/> to the specified commit and optionally resets the <see cref="Index"/> and
@@ -169,7 +169,7 @@ public interface IRepository : IDisposable
         /// <param name="commit">The target commit object.</param>
         /// <param name="signature">Identity for use when updating the reflog.</param>
         /// <param name="logMessage">Message to use when updating the reflog.</param>
-        void Reset(ResetMode resetMode, Commit commit, Signature signature = null, string logMessage = null);
+        void Reset(ResetMode resetMode, Commit commit, Signature signature, string logMessage);
 
         /// <summary>
         /// Replaces entries in the <see cref="Repository.Index"/> with entries from the specified commit.
@@ -180,7 +180,7 @@ public interface IRepository : IDisposable
         /// If set, the passed <paramref name="paths"/> will be treated as explicit paths.
         /// Use these options to determine how unmatched explicit paths should be handled.
         /// </param>
-        void Reset(Commit commit, IEnumerable<string> paths = null, ExplicitPathsOptions explicitPathsOptions = null);
+        void Reset(Commit commit, IEnumerable<string> paths, ExplicitPathsOptions explicitPathsOptions);
 
         /// <summary>
         /// Clean the working tree by removing files that are not under version control.
@@ -194,7 +194,7 @@ public interface IRepository : IDisposable
         /// <param name="reverter">The <see cref="Signature"/> of who is performing the reverte.</param>
         /// <param name="options"><see cref="RevertOptions"/> controlling revert behavior.</param>
         /// <returns>The result of the revert.</returns>
-        RevertResult Revert(Commit commit, Signature reverter, RevertOptions options = null);
+        RevertResult Revert(Commit commit, Signature reverter, RevertOptions options);
 
         /// <summary>
         /// Merge changes from commit into the branch pointed at by HEAD..
@@ -203,7 +203,7 @@ public interface IRepository : IDisposable
         /// <param name="merger">The <see cref="Signature"/> of who is performing the merge.</param>
         /// <param name="options">Specifies optional parameters controlling merge behavior; if null, the defaults are used.</param>
         /// <returns>The <see cref="MergeResult"/> of the merge.</returns>
-        MergeResult Merge(Commit commit, Signature merger, MergeOptions options = null);
+        MergeResult Merge(Commit commit, Signature merger, MergeOptions options);
 
         /// <summary>
         /// Merges changes from branch into the branch pointed at by HEAD..
@@ -212,7 +212,7 @@ public interface IRepository : IDisposable
         /// <param name="merger">The <see cref="Signature"/> of who is performing the merge.</param>
         /// <param name="options">Specifies optional parameters controlling merge behavior; if null, the defaults are used.</param>
         /// <returns>The <see cref="MergeResult"/> of the merge.</returns>
-        MergeResult Merge(Branch branch, Signature merger, MergeOptions options = null);
+        MergeResult Merge(Branch branch, Signature merger, MergeOptions options);
 
         /// <summary>
         /// Merges changes from the commit into the branch pointed at by HEAD.
@@ -221,7 +221,7 @@ public interface IRepository : IDisposable
         /// <param name="merger">The <see cref="Signature"/> of who is performing the merge.</param>
         /// <param name="options">Specifies optional parameters controlling merge behavior; if null, the defaults are used.</param>
         /// <returns>The <see cref="MergeResult"/> of the merge.</returns>
-        MergeResult Merge(string committish, Signature merger, MergeOptions options = null);
+        MergeResult Merge(string committish, Signature merger, MergeOptions options);
 
         /// <summary>
         /// Cherry picks changes from the commit into the branch pointed at by HEAD.
@@ -230,7 +230,7 @@ public interface IRepository : IDisposable
         /// <param name="committer">The <see cref="Signature"/> of who is performing the cherry pick.</param>
         /// <param name="options">Specifies optional parameters controlling cherry pick behavior; if null, the defaults are used.</param>
         /// <returns>The <see cref="MergeResult"/> of the merge.</returns>
-        CherryPickResult CherryPick(Commit commit, Signature committer, CherryPickOptions options = null);
+        CherryPickResult CherryPick(Commit commit, Signature committer, CherryPickOptions options);
 
         /// <summary>
         /// Manipulate the currently ignored files.
@@ -253,6 +253,6 @@ public interface IRepository : IDisposable
         /// <param name="path">Path of the file to blame.</param>
         /// <param name="options">Specifies optional parameters; if null, the defaults are used.</param>
         /// <returns>The blame for the file.</returns>
-        BlameHunkCollection Blame(string path, BlameOptions options = null);
+        BlameHunkCollection Blame(string path, BlameOptions options);
     }
 }

LibGit2Sharp/Repository.cs

@@ -572,7 +572,7 @@ public static string Clone(string sourceUrl, string workdirPath,
         /// <param name="path">Path of the file to blame.</param>
         /// <param name="options">Specifies optional parameters; if null, the defaults are used.</param>
         /// <returns>The blame for the file.</returns>
-        public BlameHunkCollection Blame(string path, BlameOptions options = null)
+        public BlameHunkCollection Blame(string path, BlameOptions options)
         {
             return new BlameHunkCollection(this, Handle, path, options ?? new BlameOptions());
         }
@@ -588,7 +588,7 @@ public BlameHunkCollection Blame(string path, BlameOptions options = null)
         /// <param name="options"><see cref="CheckoutOptions"/> controlling checkout behavior.</param>
         /// <param name="signature">Identity for use when updating the reflog.</param>
         /// <returns>The <see cref="Branch"/> that was checked out.</returns>
-        public Branch Checkout(string committishOrBranchSpec, CheckoutOptions options, Signature signature = null)
+        public Branch Checkout(string committishOrBranchSpec, CheckoutOptions options, Signature signature)
         {
             Ensure.ArgumentNotNullOrEmptyString(committishOrBranchSpec, "committishOrBranchSpec");
             Ensure.ArgumentNotNull(options, "options");
@@ -638,7 +638,7 @@ public Branch Checkout(string committishOrBranchSpec, CheckoutOptions options, S
         /// <param name="options"><see cref="CheckoutOptions"/> controlling checkout behavior.</param>
         /// <param name="signature">Identity for use when updating the reflog.</param>
         /// <returns>The <see cref="Branch"/> that was checked out.</returns>
-        public Branch Checkout(Branch branch, CheckoutOptions options, Signature signature = null)
+        public Branch Checkout(Branch branch, CheckoutOptions options, Signature signature)
         {
             Ensure.ArgumentNotNull(branch, "branch");
             Ensure.ArgumentNotNull(options, "options");
@@ -675,7 +675,7 @@ public Branch Checkout(Branch branch, CheckoutOptions options, Signature signatu
         /// <param name="options"><see cref="CheckoutOptions"/> controlling checkout behavior.</param>
         /// <param name="signature">Identity for use when updating the reflog.</param>
         /// <returns>The <see cref="Branch"/> that was checked out.</returns>
-        public Branch Checkout(Commit commit, CheckoutOptions options, Signature signature = null)
+        public Branch Checkout(Commit commit, CheckoutOptions options, Signature signature)
         {
             Ensure.ArgumentNotNull(commit, "commit");
             Ensure.ArgumentNotNull(options, "options");
@@ -736,7 +736,7 @@ private void CheckoutTree(
         /// <param name="commit">The target commit object.</param>
         /// <param name="signature">Identity for use when updating the reflog.</param>
         /// <param name="logMessage">Message to use when updating the reflog.</param>
-        public void Reset(ResetMode resetMode, Commit commit, Signature signature = null, string logMessage = null)
+        public void Reset(ResetMode resetMode, Commit commit, Signature signature, string logMessage)
         {
             Ensure.ArgumentNotNull(commit, "commit");
 
@@ -759,7 +759,7 @@ public void Reset(ResetMode resetMode, Commit commit, Signature signature = null
         /// <param name = "committishOrBranchSpec">A revparse spec for the commit or branch to checkout paths from.</param>
         /// <param name="paths">The paths to checkout. Will throw if null is passed in. Passing an empty enumeration results in nothing being checked out.</param>
         /// <param name="checkoutOptions">Collection of parameters controlling checkout behavior.</param>
-        public void CheckoutPaths(string committishOrBranchSpec, IEnumerable<string> paths, CheckoutOptions checkoutOptions = null)
+        public void CheckoutPaths(string committishOrBranchSpec, IEnumerable<string> paths, CheckoutOptions checkoutOptions)
         {
             Ensure.ArgumentNotNullOrEmptyString(committishOrBranchSpec, "committishOrBranchSpec");
             Ensure.ArgumentNotNull(paths, "paths");
@@ -783,7 +783,7 @@ public void CheckoutPaths(string committishOrBranchSpec, IEnumerable<string> pat
         /// If set, the passed <paramref name="paths"/> will be treated as explicit paths.
         /// Use these options to determine how unmatched explicit paths should be handled.
         /// </param>
-        public void Reset(Commit commit, IEnumerable<string> paths = null, ExplicitPathsOptions explicitPathsOptions = null)
+        public void Reset(Commit commit, IEnumerable<string> paths, ExplicitPathsOptions explicitPathsOptions)
         {
             if (Info.IsBare)
             {
@@ -806,7 +806,7 @@ public void Reset(Commit commit, IEnumerable<string> paths = null, ExplicitPaths
         /// <param name="committer">The <see cref="Signature"/> of who added the change to the repository.</param>
         /// <param name="options">The <see cref="CommitOptions"/> that specify the commit behavior.</param>
         /// <returns>The generated <see cref="LibGit2Sharp.Commit"/>.</returns>
-        public Commit Commit(string message, Signature author, Signature committer, CommitOptions options = null)
+        public Commit Commit(string message, Signature author, Signature committer, CommitOptions options)
         {
             if (options == null)
             {
@@ -992,7 +992,7 @@ private static string ReadContentFromResource(Assembly assembly, string partialR
         /// <param name="merger">The <see cref="Signature"/> of who is performing the merge.</param>
         /// <param name="options">Specifies optional parameters controlling merge behavior; if null, the defaults are used.</param>
         /// <returns>The <see cref="MergeResult"/> of the merge.</returns>
-        public MergeResult Merge(Commit commit, Signature merger, MergeOptions options = null)
+        public MergeResult Merge(Commit commit, Signature merger, MergeOptions options)
         {
             Ensure.ArgumentNotNull(commit, "commit");
             Ensure.ArgumentNotNull(merger, "merger");
@@ -1012,7 +1012,7 @@ public MergeResult Merge(Commit commit, Signature merger, MergeOptions options =
         /// <param name="merger">The <see cref="Signature"/> of who is performing the merge.</param>
         /// <param name="options">Specifies optional parameters controlling merge behavior; if null, the defaults are used.</param>
         /// <returns>The <see cref="MergeResult"/> of the merge.</returns>
-        public MergeResult Merge(Branch branch, Signature merger, MergeOptions options = null)
+        public MergeResult Merge(Branch branch, Signature merger, MergeOptions options)
         {
             Ensure.ArgumentNotNull(branch, "branch");
             Ensure.ArgumentNotNull(merger, "merger");
@@ -1033,7 +1033,7 @@ public MergeResult Merge(Branch branch, Signature merger, MergeOptions options =
         /// <param name="merger">The <see cref="Signature"/> of who is performing the merge.</param>
         /// <param name="options">Specifies optional parameters controlling merge behavior; if null, the defaults are used.</param>
         /// <returns>The <see cref="MergeResult"/> of the merge.</returns>
-        public MergeResult Merge(string committish, Signature merger, MergeOptions options = null)
+        public MergeResult Merge(string committish, Signature merger, MergeOptions options)
         {
             Ensure.ArgumentNotNull(committish, "committish");
             Ensure.ArgumentNotNull(merger, "merger");
@@ -1097,7 +1097,7 @@ internal MergeResult MergeFetchHeads(Signature merger, MergeOptions options)
         /// <param name="reverter">The <see cref="Signature"/> of who is performing the revert.</param>
         /// <param name="options"><see cref="RevertOptions"/> controlling revert behavior.</param>
         /// <returns>The result of the revert.</returns>
-        public RevertResult Revert(Commit commit, Signature reverter, RevertOptions options = null)
+        public RevertResult Revert(Commit commit, Signature reverter, RevertOptions options)
         {
             Ensure.ArgumentNotNull(commit, "commit");
             Ensure.ArgumentNotNull(reverter, "reverter");
@@ -1163,7 +1163,8 @@ public RevertResult Revert(Commit commit, Signature reverter, RevertOptions opti
                             revertCommit = this.Commit(
                                 Info.Message,
                                 author: reverter,
-                                committer: reverter);
+                                committer: reverter,
+                                options: null);
                         }
                     }
 
@@ -1185,7 +1186,7 @@ public RevertResult Revert(Commit commit, Signature reverter, RevertOptions opti
         /// <param name="committer">The <see cref="Signature"/> of who is performing the cherry pick.</param>
         /// <param name="options"><see cref="CherryPickOptions"/> controlling cherry pick behavior.</param>
         /// <returns>The result of the cherry pick.</returns>
-        public CherryPickResult CherryPick(Commit commit, Signature committer, CherryPickOptions options = null)
+        public CherryPickResult CherryPick(Commit commit, Signature committer, CherryPickOptions options)
         {
             Ensure.ArgumentNotNull(commit, "commit");
             Ensure.ArgumentNotNull(committer, "committer");
@@ -1221,7 +1222,7 @@ public CherryPickResult CherryPick(Commit commit, Signature committer, CherryPic
                     Commit cherryPickCommit = null;
                     if (options.CommitOnSuccess)
                     {
-                        cherryPickCommit = this.Commit(Info.Message, commit.Author, committer);
+                        cherryPickCommit = this.Commit(Info.Message, commit.Author, committer, null);
                     }
 
                     result = new CherryPickResult(CherryPickStatus.CherryPicked, cherryPickCommit);
@@ -1364,7 +1365,7 @@ private MergeResult NormalMerge(GitMergeHeadHandle[] mergeHeads, Signature merge
                 if (options.CommitOnSuccess)
                 {
                     // Commit the merge
-                    mergeCommit = Commit(Info.Message, author: merger, committer: merger);
+                    mergeCommit = Commit(Info.Message, author: merger, committer: merger, options: null);
                 }
 
                 mergeResult = new MergeResult(MergeStatus.NonFastForward, mergeCommit);