New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree: let contains look in subtrees #316

Merged
merged 1 commit into from Jan 20, 2014

Conversation

Projects
None yet
2 participants
@carlosmn
Member

carlosmn commented Jan 20, 2014

Allow looking in subtrees as a convenience in the 'contains'
function. As slashes are not allowed to be part of the name of an entry,
there is no ambiguity in what they mean.

This fixes #306


This does mean a bit more data copying, but it's probably not enough to warrant treating the subtree and no-subtree cases differently in the code.

Tree: let contains look in subtrees
Allow looking in subtrees as a convenience in the 'contains'
function. As slashes are not allowed to be part of the name of an entry,
there is no ambiguity in what they mean.

@jdavid jdavid merged commit 5baaf28 into libgit2:master Jan 20, 2014

1 check passed

default The Travis CI build passed
Details

@carlosmn carlosmn deleted the carlosmn:tree-deep-search branch Jan 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment