Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oid cleanups #322

Merged
merged 3 commits into from
Jan 24, 2014
Merged

Oid cleanups #322

merged 3 commits into from
Jan 24, 2014

Commits on Jan 24, 2014

  1. Oid: Deprecate 'hex' in favour of str() or unicode() 

    Python has built-in functions to get a string representation of an
object id, so let's use that instead of using a custom attribute.
    @carlosmn
    carlosmn committed Jan 24, 2014
    Configuration menu
    Copy the full SHA
    3a83cb4 View commit details
    Browse the repository at this point in the history

  2. Object: move to use an 'id' attribute instead of 'oid' 

    This looks like a left-over from the libgit2 misnaming. The current
consensus is that 'oid' is the data type and 'id' is the name of the
attribute.
    @carlosmn
    carlosmn committed Jan 24, 2014
    Configuration menu
    Copy the full SHA
    500a679 View commit details
    Browse the repository at this point in the history

  3. TreeEntry: move to use 'id' attribute for the object's id 

    Similar to the Object change, we should be using 'id' when referring to
the target's id.x
    @carlosmn
    carlosmn committed Jan 24, 2014
    Configuration menu
    Copy the full SHA
    5410128 View commit details
    Browse the repository at this point in the history