New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for libgit2 feature detection #475

Merged
merged 1 commit into from Jan 16, 2015

Conversation

Projects
None yet
2 participants
@carlosmn
Member

carlosmn commented Jan 14, 2015

This lets us ask the library whether it supports threading, https and
ssh.


I wasn't sure whether to leave it with the int as-is or convert the result to a list of strings, so you can do

if 'ssh' in pygit2.features:

instead of

if pygit2.features & pygit2.GIT_FEATURE_SSH:

The former seems more in line with what a pure-python library would do, but we do expose the underlying flags in most places.

Add support for libgit2 feature detection
This lets us ask the library whether it supports threading, https and
ssh.

@jdavid jdavid merged commit d0b00e3 into libgit2:master Jan 16, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment