Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

adapting new-error-handling in pygit2 #89

Merged
merged 1 commit into from May 19, 2012

Conversation

Projects
None yet
2 participants
Member

cholin commented May 19, 2012

New error handling in libgit2 0.17 is now done the posix way. One error code for each expected failure,
and a generic error code for all critical ones. The last critical error can be accessed by giterr_last().
It returns a pointer to the global error struct. For more information see docs/error-handling.md in libgit2.

@cholin cholin adapting new-error-handling in pygit2
New error handling in libgit2 is now done the posix way. One error code for each expected failure,
and a generic error code for all critical ones. The last error can be accessed by giterr_last().
It returns a pointer to the global error struct.

For more information see docs/error-handling.md in libgit2.
8dd0c18
Member

jdavid commented May 19, 2012

This fixes building pygit2 with libgit2 v0.17, cool. But unit tests do not yet pass. If you intend to continue I will wait for the new patches before merging. Thanks!

Member

cholin commented May 19, 2012

hmm have you tested it with libgit2 v0.17 (ad5df35a47d56c3d716d7a56eac4aeb611987c11) ?
on my local machine every test passes (python2 and 3).

running test
running build
running build_ext
building 'pygit2' extension
creating build
creating build/temp.linux-x86_64-2.7
gcc -pthread -fno-strict-aliasing -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -DNDEBUG -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -fPIC -I/usr/local/include -I/usr/include/python2.7 -c pygit2.c -o build/temp.linux-x86_64-2.7/pygit2.o
creating build/lib.linux-x86_64-2.7
gcc -pthread -shared -Wl,-O1,--sort-common,--as-needed,-z,relro,--hash-style=gnu build/temp.linux-x86_64-2.7/pygit2.o -L/usr/local/lib -L/usr/lib -lgit2 -lpython2.7 -o build/lib.linux-x86_64-2.7/pygit2.so
..................................................................
----------------------------------------------------------------------
Ran 66 tests in 0.257s

OK
Member

jdavid commented May 19, 2012

err, you are right, :)

merging now...

@jdavid jdavid merged commit 8dd0c18 into libgit2:master May 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment