Use gem instead of requiring libgit2 #80

Closed
stereobooster opened this Issue Jun 20, 2012 · 3 comments

Comments

Projects
None yet
4 participants
@stereobooster
Contributor

stereobooster commented Jun 20, 2012

Create gem which provides binaries of libgit2. The same way as it done for v8 with libv8

@tenderlove

This comment has been minimized.

Show comment
Hide comment
@tenderlove

tenderlove Jun 20, 2012

Contributor

libgit2 doesn't take as long to compile as v8, so we may do this in the future. I think it's a very low priority right now though.

Contributor

tenderlove commented Jun 20, 2012

libgit2 doesn't take as long to compile as v8, so we may do this in the future. I think it's a very low priority right now though.

@vsizov

This comment has been minimized.

Show comment
Hide comment
@vsizov

vsizov Oct 15, 2012

That would make your test more trusty.
I do now:

require "rugged"
r = Rugged::Repository.new("/tmp/example.git") => #<Rugged::Repository:0x00000002779460 @encoding=#<Encoding:UTF-8>>
r.last_commit

And getting error:

NoMethodError: undefined method `last_commit' for #<Rugged::Repository:0x00000002e939a8>

When I am using compiled version then everything works fine.

vsizov commented Oct 15, 2012

That would make your test more trusty.
I do now:

require "rugged"
r = Rugged::Repository.new("/tmp/example.git") => #<Rugged::Repository:0x00000002779460 @encoding=#<Encoding:UTF-8>>
r.last_commit

And getting error:

NoMethodError: undefined method `last_commit' for #<Rugged::Repository:0x00000002e939a8>

When I am using compiled version then everything works fine.

@arthurschreiber

This comment has been minimized.

Show comment
Hide comment
@arthurschreiber

arthurschreiber Jul 16, 2013

Member

I'm not even sure what this issue is exactly about. If you want to have libgit2 statically linked compiled into Rugged, the simplest way is to use bundler and specify Rugged as a git gem dependency, with the submodules: true option.

I'll close this for now - please reply to this issue if you've any more questions.

Member

arthurschreiber commented Jul 16, 2013

I'm not even sure what this issue is exactly about. If you want to have libgit2 statically linked compiled into Rugged, the simplest way is to use bundler and specify Rugged as a git gem dependency, with the submodules: true option.

I'll close this for now - please reply to this issue if you've any more questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment