Windows fixes #237

Merged
merged 12 commits into from Jul 31, 2013

Projects

None yet

2 participants

Member

This is a collection of issues that I found while runnning the rugged testsuite on windows.

I really don't like having to trigger GC.start, and I'd propose that we move to a resource management model more inline with how File and other IO work, but I'll open a separate PR for that.

Member

👍 just had to start doing this in mysql2 to make sure idle connections weren't sitting around any longer than they needed to.

Member

@brianmario care to elaborate?

Member

So as of 0.3.12 and 0.2.19 we started doing our own ref-counting on Mysql2::Client instances to make sure it wouldn't be freed until all of the Mysql2::Result objects generated from it had been freed. This was due to a limitation in libmysql.

As a result, the Client objects were hanging around a lot longer in the tests and we're creating all kinds of connections to test various connection options and stuff. So I had to go back through the test suite and make sure we closed every connection we opened as soon as it wasn't needed.

@arthurschreiber arthurschreiber referenced this pull request Jul 25, 2013
Merged

Add Rugged cross compilation support #241

2 of 2 tasks complete
Member
C:\rugged>rake
git submodule update --init
install -c tmp/i386-mingw32/rugged/2.0.0/rugged.so lib/rugged/rugged.so
Run options: --seed 36787

# Running tests:

................................................................................
................................................................................
................................................................................
.........................................

Finished tests in 19.428343s, 14.4634 tests/s, 44.7799 assertions/s.

281 tests, 870 assertions, 0 failures, 0 errors, 0 skips

Depends on libgit2/libgit2#1748 to be merged, then I'll pull this in, I think.

@arthurschreiber arthurschreiber merged commit 098ddbc into libgit2:development Jul 31, 2013

1 check passed

default The Travis CI build passed
Details
@arthurschreiber arthurschreiber deleted the arthurschreiber:windows-fixes branch Jul 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment