From c1f7dfe17e42142569813259cb8f6f9325bcee85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Jeanneret?= Date: Fri, 25 Mar 2022 11:38:47 +0100 Subject: [PATCH] Ensure the machine-id operation is the last one We must ensure the modified image doesn't have any content in /etc/machine-id file. This will then trigger the usual systemd-machine-id-setup during the first boot of the image, ensuring we'll get an as unique as possible ID. This is mandatory, since the tools are generating a machine-id at different stages, for instance in order to ensure packages are installing without any issue[1] Of course, if the operator wants to get an actual machine-id, they can just disable the "machine-id" operation. Note that it's enabled by default, so the issue is more about ordering than anything. [1] For instance here: https://github.com/rwmjones/guestfs-tools/blob/3a498512f58bc431db490e96cdb712b19389bda4/customize/customize_run.ml#L170-L188 --- sysprep/sysprep_operation_machine_id.ml | 1 + 1 file changed, 1 insertion(+) diff --git a/sysprep/sysprep_operation_machine_id.ml b/sysprep/sysprep_operation_machine_id.ml index dbf8ce242..4c26621e9 100644 --- a/sysprep/sysprep_operation_machine_id.ml +++ b/sysprep/sysprep_operation_machine_id.ml @@ -32,6 +32,7 @@ let machine_id_perform (g : Guestfs.guestfs) root side_effects = let op = { defaults with + order = 999; name = "machine-id"; enabled_by_default = true; heading = s_"Remove the local machine ID";