Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 hivex gives strings for REG_BINARY values #2

Closed
kupiakos opened this issue Jan 31, 2014 · 1 comment
Closed

python3 hivex gives strings for REG_BINARY values #2

kupiakos opened this issue Jan 31, 2014 · 1 comment

Comments

@kupiakos
Copy link
Contributor

In 1.3.8 in python 3.3, the hivex module gave bytes objects for REG_BINARY values.
In 1.3.9, it started giving str objects for REG_BINARY values, or anything using value_value() it seems. Binary data should be kept as binary data. This is definitely a regression.
This broke any code trying to interpret binary objects, as the struct library does not accept str objects as valid binary data.
It doesn't make a lot of sense why one wouldn't want bytes objects from REG_BINARY objects.

hillu added a commit that referenced this issue Feb 3, 2014
This fixes Github issue #2 reported by "kupiakos".

<#2>
@ptoscano
Copy link
Contributor

This has been fixed with commit 97bbe49 by Hilko Bengen.
It will be available in hivex >= 1.3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants