Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on May 28, 2015
  1. @hacxman @rwmjones
Commits on May 27, 2015
  1. @rwmjones
  2. @rwmjones

    builder: armv7l: Fix build script for Fedora 22 release.

    rwmjones authored
    (The same change as was made in
    commit c4a54e0).
Commits on May 26, 2015
  1. @rwmjones

    Version 1.29.44.

    rwmjones authored
  2. @rwmjones
  3. @rwmjones

    lib: Limit space and time used by 'qemu-img info' subprocess.

    rwmjones authored
    After fuzzing 'qemu-img info' I found that certain files can cause the
    command to use lots of memory and time.  Modify the command
    mini-library to allow us to place resource limits on subprocesses, and
    use these to limit the amount of space and time used by 'qemu-img info'.
  4. @rwmjones
  5. @rwmjones
  6. @rwmjones

    generator: Move version first added to generator.

    rwmjones authored
    This change was generated automatically using the following Perl
    script, with a few hand corrections afterwards.
    
    use strict;
    my %map;
    open ADDED, "src/api-support/added" or die "added: $!";
    while (<ADDED>) {
        chomp;
        if (/^guestfs_(.*)_(argv|va|opts) /) {
            # ignore _argv, _va, _opts entries.
        }
        elsif (/^guestfs_(compare|copy)_/) {
            # ignore guestfs_compare_*, guestfs_copy_* struct functions.
        }
        elsif (/^guestfs_(.*) [01]\.(\d+)\.(\d+)$/) {
            $map{$1} = [1, $2, $3];
        }
        elsif (/^guestfs_(.*) 0\.(\d+)$/) {
            $map{$1} = [0, 0, $2];
        }
        else {
            die "cannot parse line: `$_'\n"
        }
    }
    close ADDED;
    open ACTIONS, "generator/actions.ml" or die "actions.ml: $!";
    open ACTIONS_OUT, ">generator/actions.ml.out" or die "actions.ml.out: $!";
    while (<ACTIONS>) {
        chomp;
        if (/name = "(.*)";$/ && exists $map{$1}) {
            my @v = @{$map{$1}};
            $_ .= sprintf (" added = (%d, %d, %d);", $v[0], $v[1], $v[2]) ;
            delete $map{$1};
        }
        print ACTIONS_OUT "$_\n";
    }
    close ACTIONS_OUT;
    close ACTIONS;
  7. @rwmjones
  8. @rwmjones

    Update API support.

    rwmjones authored
  9. @rwmjones
  10. @rwmjones

    api: Don't truncate /dev/stdout or /dev/stderr when used as FileOut.

    rwmjones authored
    In APIs such as guestfs_download, when the FileOut parameter exactly
    matches "/dev/stdout" or "/dev/stderr", don't reopen the possibly
    redirected output file with O_TRUNC (truncate).  Instead dup the file
    descriptor.
    
    This magic behaviour doesn't happen for /dev/fd/* (or any other output
    file) allowing callers the choice of using /dev/stderr or /dev/fd/2
    depending on whether or not they want truncation.
    
    This works around an annoying virt-builder bug.  If you do:
    
      $ virt-builder fedora-21 --install no_such_package -v -x >& /tmp/log
    
    then when the `--install' command fails, virt-builder will download
    the log file using `guestfs_download (g, log, "/dev/stderr")'.  Since
    this truncates the redirected /dev/stderr, the final log file is
    truncated and corrupted.
    
    With this patch the log file is no longer corrupted.
  11. @rwmjones
  12. @rwmjones

    builder: Add Fedora 22 image.

    rwmjones authored
Commits on May 21, 2015
  1. @rwmjones
Commits on May 20, 2015
  1. @rwmjones

    v2v: Fix confusion over rhel-7 virt-v2v conversion server / appliance.

    rwmjones authored
    This fixes commit 4c7fb62
    and updates commit 4e4ece5.
Commits on May 19, 2015
  1. @rwmjones
  2. @rwmjones

    p2v: Explicitly depend on nm-connection-editor.

    rwmjones authored
    Previously it was only being pulled in implicitly.  However virt-p2v
    runs this binary from the "Configure Network" button.
    
    This fixes commit e464774.
  3. @rwmjones
Commits on May 18, 2015
  1. @chenhanxiao @rwmjones

    resize: add sector size in debug_partition

    chenhanxiao authored rwmjones committed
    This patch will add fields of sector size for:
      - partition sector data size
      - target partition sector data size
    
    Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
Commits on May 15, 2015
  1. @rwmjones

    Version 1.29.43.

    rwmjones authored
  2. @rwmjones

    builder: sigchecker: Fix error message.

    rwmjones authored
    Error messages are automatically wrapped, and don't require a newline
    at the end.
  3. @rwmjones
  4. @rwmjones
  5. @rwmjones

    ocaml tools: Use global variable to store quiet (--quiet) flag.

    rwmjones authored
    Don't pass this flag to dozens of functions.
    
    This change is analogous to the change made in
    commit 79fc607 for the -v & -x flags.
  6. @rwmjones
  7. @rwmjones
  8. @rwmjones

    customize: Give a clear error message if host_cpu not compatible with…

    rwmjones authored
    … guest arch.
    
    In cases where we are asked to run commands in the guest (eg.  options
    such as --run-command or --install), give a clear error in the cases
    where the guest arch is not compatible with the host arch.
    
    Similar code existed in virt-builder, but I have removed that.  Users
    will still get an error message, it will just happen a bit later on.
    
    There is a slight change in semantics here, in that architectures are
    no longer normalized when matching, but that's probably fine since
    `virt-builder -l' prints the exact arch string that people should use.
  9. @rwmjones

    ocaml tools: Only tell people to use -v -x if they're not already set…

    rwmjones authored
    … (RHBZ#1167623).
    
    When you get an error in tools, it will print a message like:
    
      If reporting bugs, run virt-v2v with debugging enabled and include the
      complete output:
    
        virt-v2v -v -x [...]
    
    Only print this message if -v or -x were not already specified on the
    command line.
  10. @rwmjones

    ocaml tools: Use global variables to store trace (-x) and verbose (-v…

    rwmjones authored
    …) flags.
    
    Don't pass these flags to dozens of functions.
  11. @rwmjones

    ocaml tools: Define Common_utils.prog and don't pass it to every func…

    rwmjones authored
    …tion.
    
    This large commit is just code refactoring.  Instead of having
    every OCaml tool define 'prog' the same way, always as:
    
      let prog = Filename.basename Sys.executable_name
    
    move that into a single place, Common_utils.prog.  Then we can use
    that global value everywhere else, instead of having to pass it as a
    parameter into a dozen different functions.
  12. @rwmjones

    resize: Remove unnecessary 'prog' from error message.

    rwmjones authored
    The common error function already prints the program name, so
    we don't need to print it twice.
    
    Before:
    
      $ virt-resize --expand ""
      virt-resize: error: virt-resize: empty --expand option
    
    After:
    
      $ virt-resize --expand ""
      virt-resize: error: empty --expand option
  13. @rwmjones
Commits on May 14, 2015
  1. @rwmjones

    p2v: Display network card MAC address and vendor in conversion dialog…

    rwmjones authored
    … (RHBZ#855059).
    
    This displays the MAC address and vendor next to each network
    interface, aiding users in determining which network cards they want
    to transfer to the virtualized machine.
Something went wrong with that request. Please try again.