Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Aug 28, 2015
  1. @rwmjones

    Version 1.31.3.

    rwmjones authored
  2. @rwmjones
  3. @rwmjones

    customize: Use setarch when running commands on i686 guest (RHBZ#1256…

    rwmjones authored
    …405).
    
    When running (eg) dnf on a 32 bit i686 guest when the host is 64 bit
    x86_64, dnf believes it is running on a 64 bit machine and so tries to
    install x86_64 packages.  We can 'trick' dnf into believing it's a 32
    bit machine using the setarch program.
    
    $ virt-builder fedora-22 --arch i686 --install 'gperf'
    ...
    [  27.4] Installing packages: gperf
    ...
    Running transaction test
    Error: Transaction check error:
      package libgcc-5.1.1-4.fc22.x86_64 is intended for a different architecture
    ...
    
    The use of a heredoc to solve quoting issues comes from:
    http://stackoverflow.com/a/3435460
    
    Thanks: Jan Sedlák for finding the solution.
  4. @rwmjones

    v2v: -i libvirtxml: Map empty network or bridge name to default (RHBZ…

    rwmjones authored
    …#1257895).
    
    As with the -i ova driver, if an unnamed network is found, map it to
    "eth0", "eth1" etc.
  5. @rwmjones

    v2v: Convert xpath_to_* to use xpath convenience functions.

    rwmjones authored
    In -i libvirtxml, -i ova and -o libvirt drivers, replace the ad hoc
    xpath_to_* functions with use of the new xpath convenience functions
    introduced in the previous commit.
    
    This is not entirely refactoring because I fixed a few bugs found by
    type safety.
  6. @rwmjones
  7. @rwmjones

    v2v: vcenter: Calculate dcPath correctly (RHBZ#1256823).

    rwmjones authored
    Previously given a path such as:
    
      vpx://vcenter/Folder/Datacenter/esxi
    
    we calculated dcPath=Folder.  However this is obviously wrong.  We
    should chop the path at the final (esxi) element to give
    dcPath=Folder/Datacenter.
  8. @rwmjones

    v2v: vcenter: Change function get_datacenter -> get_dcPath.

    rwmjones authored
    In vCenter, the datacenter is identified by a path, and the parameter
    used for this is called 'dcPath'.  Rename the function to avoid any
    confusion about what we're getting here.
    
    This is just renaming function/variable names and has no other effect.
  9. @rwmjones

    handle --debug-gc universally via at_exit hook

    Roman Kagan authored rwmjones committed
    Several tools handle --debug-gc command-line option, by explicitly
    forcing GC on every exit path.  This is tedious and prone to forgetting
    some of the exit paths.
    
    Instead, add a generic handler for --debug-gc, which installs an at_exit
    hook to do the GC consistency check, and which can be called right in
    the command-line parser.  Also adjust all users of --debug-gc to use
    that handler.
    
    Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
Commits on Aug 27, 2015
  1. @rwmjones

    p2v: Add a test for the PXE boot path (RHBZ#1256222).

    rwmjones authored
    Build the P2V disk image and boot it.  We don't actually use PXE
    specifically, but we do test the whole PXE / kernel command line path
    much more thoroughly.
    
    This is a 'check-slow' test because it takes ages to run.
  2. @rwmjones

    p2v: Add SSH Identity URL.

    rwmjones authored
    Allow SSH identities (ie. secret keys) to be used for authentication
    instead of passwords.
  3. @rwmjones

    Revert "p2v: Add tip about the root password of the virt-v2v conversi…

    rwmjones authored
    …on server appliance."
    
    This reverts commit 35efaf8.
  4. @rwmjones

    p2v: Wait for network to come online before testing connection (RHBZ#…

    rwmjones authored
    …1256222).
    
    When using the virt-p2v ISO in command line mode, we did not wait for
    the network to come online before starting virt-p2v.  Therefore
    virt-p2v could exit with an error when testing the ssh connection (or
    on the other hand, it might work randomly).  If the user logs in and
    runs 'launch-virt-p2v' by hand, then it would usually work because the
    network had been brought online in the meantime.
    
    Fix this by waiting for NetworkManager to bring the connection online
    before calling test_connection().  Note that the obvious way to fix
    this (changing the systemd service to wait for network-online.target)
    does *not* work - I added a comment to the service about this.
    
    Thanks: Tingting Zheng
Commits on Aug 25, 2015
  1. @ptoscano
  2. @ptoscano

    inspect: recognize the ALT Linux distribution

    ptoscano authored
    Check its presence ahead of /etc/redhat-release, as the distro provides
    it and thus previously it was recognized as "redhat-based".
Commits on Aug 24, 2015
  1. @ptoscano

    v2v: ignore missing kernels from grub (RHBZ#1230412)

    ptoscano authored
    Raise a warning for each kernel specified in grub which does not
    actually exist, keep going on with the conversion using the remaining
    (existing) kernels.
  2. @ptoscano
  3. @ptoscano

    ocaml: dynamically generate the content of Guestfs.Errno

    ptoscano authored
    Put in a list the errnos to expose, filling the content of the
    Guestfs.Errno submodule from that.
    Also, generate a separate guestfs-c-errnos.c with the implementations of
    the functions returning the errno codes.
    
    Only code motion and refactoring, no actual changes on the content of
    the ocaml Guestfs module.
Commits on Aug 20, 2015
  1. @ptoscano

    configure: look for "java" as directory for Java in lib64 too

    ptoscano authored
    On 64-bit openSUSE versions, /usr/lib64/jvm/java provides the symlink to
    the default Java version.
Commits on Aug 19, 2015
  1. @ptoscano

    appliance: explicitly add libyajl on Mageia

    ptoscano authored
    It seems yajl was bringing it, but seems not on Mageia 5.  Leave yajl
    for older versions.
Commits on Aug 13, 2015
  1. @rwmjones

    FAQ: the -> and in previous commit.

    rwmjones authored
    This fixes commit 571fca8.
  2. @rwmjones
  3. @rwmjones

    Version 1.31.2.

    rwmjones authored
  4. @rwmjones

    builder/website: Fix EXTRA_DIST.

    rwmjones authored
    This fixes commit 190a9f4 and
    commit 864ca48.
  5. @rwmjones

    p2v: Modify some partial match regexps to work with pcre 7.8.

    rwmjones authored
    pcre < 8 has limitations on the types of partial matching
    possible.  As noted in the pcrepartial(3) man page, these can
    be worked around by adding non-capturing parentheses around
    various subexpressions, as I have done here.
  6. @rwmjones
  7. @rwmjones

    p2v: Print an error if gtk_init_check fails.

    rwmjones authored
    Apparently gtk_init_check doesn't (always?) print an error message
    when it returns false, so virt-p2v just exits without any message.
    
    This was observed on RHEL 6 when $DISPLAY was not set.
  8. @rwmjones
  9. @rwmjones

    v2v: Help RHEL 6 OCaml to determine type of class.

    rwmjones authored
    File input_libvirt_other.ml, line 1, characters 0-1:
    Error: The implementation input_libvirt_other.ml
           does not match the interface input_libvirt_other.cmi:
           Class declarations do not match:
             class virtual input_libvirt :
               'a ->
               string option ->
               string ->
               object
                 method adjust_overlay_parameters : Types.overlay -> unit
                 method as_options : string
                 method virtual source : unit -> Types.source
               end
           does not match
             class virtual input_libvirt :
               string option ->
               string option ->
               string ->
               object
                 method adjust_overlay_parameters : Types.overlay -> unit
                 method as_options : string
                 method virtual source : unit -> Types.source
               end
           A parameter has type 'a but is expected to have type string option
  10. @rwmjones

    v2v: Hide StringMap functions we're not actually using.

    rwmjones authored
    In RHEL 6 OCaml, some of these functions were not part of the Map
    class, giving an error.  Hide the ones we aren't using.
  11. @rwmjones

    handle: Move #pragma out of functions.

    rwmjones authored
    RHEL 6 gcc did not support #pragma within functions.
  12. @rwmjones
  13. @rwmjones

    v2v: -oa preallocated for qcow2 output now fully allocates the file (…

    rwmjones authored
    …RHBZ#1251909).
    
    When the output format is qcow2 and -oa preallocated is used,
    previously it would only allocate the metadata.  That was a regression
    over previous behaviour of virt-v2v 0.9.  Change it so it allocates
    the full file size in this case.
  14. @rwmjones

    disk-create: Allow preallocation off/metadata/full.

    rwmjones authored
    For raw, this allows "off" as a synonym for "sparse" (to make it
    consistent with qcow2).
    
    For qcow2, this allows "sparse" as a synonym for "off".
    
    It also adds qcow2 "full" preallocation, which is actually mapped to
    the qemu option "falloc" (see arguments about this on the qemu-devel
    mailing list, which we lost).
    
    This also updates the test.
Commits on Aug 12, 2015
  1. @ptoscano

    builder: normalize architectures

    ptoscano authored
    Normalize the target architecture, and also each architecture when
    checking for a compatible image.
    
    This sort of reverts the effects of
    commit 8864c47, but at least it is
    possible to build e.g. Debian-based amd64 images on any x86_64 system
    without being considered as foreign architecture.
Something went wrong with that request. Please try again.