Skip to content
Commits on Feb 10, 2016
  1. @rwmjones

    docs: Add recipe for FUSE-mounting a Windows guest with drive letters.

    rwmjones committed
    Thanks: Pino Toscano, Hilko Bengen.
  2. @rwmjones

    docs: Alphabetize headings in guestfs-recipes(1).

    rwmjones committed
    No change, just reorder a section so they are in alphabetical order.
Commits on Feb 9, 2016
  1. @rwmjones

    v2v: move virtio_win to windows_virtio

    Roman Kagan committed with rwmjones
    Now that all the stuff related to Windows virtio drivers has been moved
    into a dedicated module, it makes sense to move the definition of
    virtio_win there, too, and stop passing it around as a parameter.
    Signed-off-by: Roman Kagan <>
  2. @rwmjones

    Version 1.33.11.

    rwmjones committed
  3. @ptoscano

    tmpdirs: fix typo in variable name

    ptoscano committed
    On mkdtemp error, free tmppath and not tmpdir (which is CLEANUP_FREE).
    Fixes commit 673a7a9.
  4. @ptoscano

    tmpdirs: centralize permissions handling

    ptoscano committed
    Move to lazy_make_tmpdir the logic for making world-readable (but only
    for root) newly-created temporary directories, removing the non-fatal
    code doing that in guestfs_impl_launch.
    Followup of commit 772f649.
  5. @ptoscano

    lib: fix sockdir for root

    ptoscano committed
    When running as root libvirt will launch qemu as qemu.qemu, which will
    not be able to read inside the socket directory in case it is set as
    XDG_RUNTIME_DIR under /run/user/0.
    Since normal users don't need particular extra access permissions for
    their sockdirs, restrict /tmp as only possible sockdir for root,
    changing the permissions only for this user (and making this operation
    Fixes commit 55202a4 and
    commit 7453952.
Commits on Feb 8, 2016
  1. @rwmjones

    Version 1.33.10.

    rwmjones committed
  2. @ptoscano @rwmjones

    tests: reduce sizes of scratch disks to 2 GB

    ptoscano committed with rwmjones
    1 GB should be enough to create a btrfs filesystem, even with 64K page
    size; hence, make the /dev/sda and /dev/sdb test devices smaller so
    there is less space taken during the test run.
    Followup of commit 8ffad75 and
    commit 9e9b648.
  3. @rwmjones
  4. @rwmjones

    launch: libvirt: Debug sockdir not tmpdir.

    rwmjones committed
    Fixes commit 55202a4.
Commits on Feb 6, 2016
  1. @Maners @rwmjones

    inspect: get windows drive letters for GPT disks.

    Maners committed with rwmjones
    This patch updates the guestfs_inspect_get_drive_mappings API call to
    also return drive letters for GPT paritions. Previously this worked
    only for MBR partitions. This is achieved by matching the GPT partition
    GUID with the info stored in the blob from
    HKLM\SYSTEM\MountedDevices\DosDevices keys. For GPT partions this blob
    contains a "DMIO:ID:" prefix followed by a 16 byte binary GUID.
Commits on Feb 5, 2016
  1. @rwmjones

    Version 1.33.9.

    rwmjones committed
  2. @rwmjones

    lib: Stop exporting the safe_malloc, etc. functions.

    rwmjones committed
    As was forewarned in the comment, stop exporting these functions
    outside the library.
  3. @rwmjones
  4. @rwmjones
  5. @rwmjones
  6. @rwmjones
  7. @rwmjones
  8. @rwmjones

    java: Fix documentation of @throws.

    rwmjones committed
    The javadoc @throws directive requires a string documenting
    when the exception is thrown.
  9. @rwmjones

    v2v: Move the other OVMF paths into the core library.

    rwmjones committed
    Refactoring change, continuing the theme from the previous commit.
Commits on Feb 4, 2016
  1. @rwmjones

    aarch64: Use a common table of AAVMF paths.

    rwmjones committed
    Previously the code had two places where an identical set of AAVMF
    paths were stored.  Put this information into one place.
    This is just refactoring.
  2. @ptoscano

    customize: add globbing for --delete

    ptoscano committed
    Support globbing in paths passed to --delete, telling glob to not
    return directories with leading slash.
    This re-adds back globbing for --delete in virt-sysprep, which was
    available before the integration with common code from virt-customize.
  3. @ptoscano

    daemon: glob: add optarg to control trailing slash for dirs

    ptoscano committed
    Add a new optional bool "directoryslash" to indicate whether the caller
    wants trailing slashes in names of directories, defaulting to true (the
    current behaviour); this helps with interoperability with other tools
    (such as rm).
    Related to RHBZ#1293271.
  4. @ptoscano

    sysprep, get-kernel: explicit the Guestfs parameter

    ptoscano committed
    Help the OCaml compiler by expliciting Guestfs.guestfs as type for 'g'
    in some functions.
Commits on Feb 3, 2016
  1. @rwmjones

    v2v: Replace "=" by "_" in OVF .meta DESCRIPTION field.

    rwmjones committed
    The current VDSM .meta file parser is incorrect:
    When parsing the key=value fields in the .meta file, it uses the
    Python expression:
      key, value = l.split("=")
    which throws an exception "ValueError: too many values to unpack" if
    the value part also contains an "=" character (because split returns
    an n-tuple with n > 2).  The correct way to split the string in this
    situation is to use l.split("=", 1).
    In commit 399e031 I changed the
    DESCRIPTION field in .meta so that in RHEL it would look like this:
      DESCRIPTION=generated by libguestfs 1.32.2rhel=7,release=1.el7,libvirt
    thus containing an "=" character in the value and throwing an
    exception in VDSM.
    Although this is a bug in VDSM which needs to be fixed separately,
    change any occurrence of "=" in the value to "_" to avoid this
    Thanks: Derrick Ornelas for helping to diagnose this bug and finding
    the offending code in VDSM.
  2. @rwmjones

    tests: btrfs: Use a 2000 MB partition for btrfs test (instead of 200 …

    rwmjones committed
    One of the mkfs-btrfs tests used two 200 MB partitions.  That isn't
    enough to create a btrfs filesystem on aarch64 (with 64K page size).
    Since we now have a 10 GB disk, we can make the test partition 10
    times larger.
  3. @rwmjones

    tests: btrfs: Don't test --leafsize, and use --nodesize 64K.

    rwmjones committed
    In btrfs-progs 4.4, the --leafsize parameter is deprecated.  It's now
    just an alias for --nodesize.
    On aarch64, --nodesize 4096 does not work because it's smaller than
    the page size (64K).  Luckily we can test a 64K nodesize on any
    platform, so use that instead.
  4. @rwmjones

    tests: Increase the size of the /dev/sda and /dev/sdb test devices.

    rwmjones committed
    Previously these were rather small - just 500 MB.  This is too small
    to create a btrfs device on aarch64 (where page size may be 64K), and
    barely enough even on x86-64.  This change makes both these devices
    10 GB, and adjusts a few tests so they continue to pass.
  5. @rwmjones

    Version 1.33.8.

    rwmjones committed
  6. @rwmjones

    resize: Use sparse copy for extended partitions unless --no-sparse.

    rwmjones committed
    Thanks: Maxim Perevedentsev
  7. @ptoscano

    generator: simplify generated code for always-available features

    ptoscano committed
    Just refer to the dummy function directly, instead of using #define's.
  8. @ptoscano

    New API: get-sockdir

    ptoscano committed
    Introduce a new read-only API to get a path where to store temporary
    sockets: this is different from tmpdir, as we need short paths for
    sockets (due to sockaddr_un::sun_path), and it is either
    XDG_RUNTIME_DIR if set, or /tmp; adapt guestfs_int_create_socketname
    to create sockets in that location.
    Furthermore, print sockdir and XDG_RUNTIME_DIR in test-tool for
  9. @ptoscano

    launch: add internal helper for socket paths creation

    ptoscano committed
    Introduce an internal helper to create paths for sockets -- will be
    useful for changing later the logic for placing sockets.
    Futhermore, check that the length of sockets won't overflow the buffer
    for their filenames.
  10. @ptoscano

    lib: extract lazy tmpdir creation helper

    ptoscano committed
    Extract the bit of code for lazy creation of a temporary directory, so
    it can be used for more directories as well.
    This is just code motion, with no behaviour changes.
Something went wrong with that request. Please try again.