Skip to content
Branch: master
Commits on Jul 4, 2019
  1. v2v: Allow Windows virtio ISO to be a block device as well as a regul…

    rwmjones committed Jul 4, 2019
    …ar file.
    Thanks: Steven Rosenberg
Commits on May 31, 2019
  1. python: PYTHON_LIBS is not set in Python 3.8 (RHBZ#1705482).

    rwmjones committed May 31, 2019
    Python 3.8 no longer links C extensions to -lpython, instead relying
    on the fact that the python binary itself already contains those
    symbols.  This means $PYTHON_LIBS is empty and so the Python bindings
    are not built.
    Use a different test to see if the python module is available.
Commits on May 29, 2019
  1. appliance: Remove /etc/dhcp/dhclient-enter-hooks.d/resolved.

    rwmjones committed Apr 18, 2019
    Workaround for Ubuntu which uses this script to try to start a systemd
    service.  That won't work because systemd is not used inside the
    appliance.  See:
    Thanks: Ioanna Alifieraki
Commits on May 10, 2019
Commits on May 4, 2019
Commits on Apr 15, 2019
  1. v2v: Move have_selinux to utils.

    rwmjones committed Apr 4, 2019
    This is not quite a neutral refactoring, because it means we now run
    the getenforce command every time virt-v2v starts up.  However it's a
    trivial command that reads a single /sys file and it can't fail even
    if the command is missing or on platforms that know nothing about
  2. common/mlstdutils: Add String.unix2dos function.

    rwmjones committed Apr 15, 2019
    Simple string line ending replacement convenience function.
Commits on Apr 1, 2019
  1. lib: qemu: rbd: Properly escape IPv6 addresses.

    rwmjones committed Apr 1, 2019
    Each ':' character in the address must be escaped from qemu.
    Thanks: Jonathan Wright
Commits on Mar 27, 2019
  1. lib: direct: Set QEMU_AUDIO_DRV=none when testing schema.

    rwmjones committed Mar 23, 2019
    Schema parsing was failing with errors such as:
    libguestfs: QMP parse error: '[' or '{' expected near end of file (ignored)
    This happened because the QMP command was actually completely failing
    and never printing a result at all.  This happens because the qemu
    audio driver can't be set up without a console.  We can suppress this
    by setting the environment variable QEMU_AUDIO_DRV=none, which is the
    same thing that libvirt does, and also the same thing that we are
    already doing when launching the real appliance subprocess.
    See also:
Commits on Mar 26, 2019
Commits on Jan 24, 2019
  1. build: Reduce -Wformat-overflow=2 to =1.

    rwmjones committed Jan 21, 2019
    GCC 9 gives this error:
    qemuopts.c: In function 'qemuopts_to_config_channel':
    qemuopts.c:987:29: error: '%.*s' directive output between 0 and 2147483647 bytes may exceed minimum required size of 4095 [-Werror=format-overflow=]
      987 |             fprintf (fp, "  %.*s = ", (int) k, values[j]);
          |                             ^~~~
    qemuopts.c:987:26: note: assuming directive output of 1 byte
      987 |             fprintf (fp, "  %.*s = ", (int) k, values[j]);
          |                          ^~~~~~~~~~~
    See discussion at the following GCC bug:
Commits on Jan 17, 2019
Commits on Jan 16, 2019
  1. Version 1.40.0.

    rwmjones committed Jan 15, 2019
  2. po: Drop ca and pt_BR from linguas.

    rwmjones committed Jan 16, 2019
    Commit 4252a49 dropped the PO files
    for ca (Catalan) and pt_BR (Brazilian Portuguese).  However it did not
    drop these languages from the linguas line in the Makefile resulting
    in a build failure.
  3. configure: Move remaining detection of p2v features to m4/guestfs-v2v…

    rwmjones committed Jan 16, 2019
    ./configure output now contains a distinct section for v2v and p2v:
      --- Checking the virt-v2v and virt-p2v dependencies ---
      checking for the nbdkit python plugin name... python3
      checking for --with-gtk option... 2
      checking for GTK... yes
      checking for DBUS... yes
      checking if we can build virt-p2v... yes, with Gtk 2
    Thanks: Pino Toscano.
  4. v2v: -o rhv-upload: Allow configure to set the nbdkit Python version.

    rwmjones committed Jan 8, 2019
    No functional change, but it does allow downstream distributions to
    adjust the nbdkit Python plugin used by virt-v2v -o rhv-upload mode:
    ./configure --with-virt-v2v-nbdkit-python-plugin=...
Commits on Jan 15, 2019
  1. po-docs: uk: Fix inconsistent use of \n in translation.

    rwmjones committed Jan 15, 2019
    Invalid po file ./uk.po:
    ./uk.po:90428: 'msgid' and 'msgstr' entries do not both begin with '\n'
    msgfmt: found 1 fatal error
  2. docs: Finalize release notes for 1.40.

    rwmjones committed Jan 15, 2019
    Updates commit 0ce8ecd.
Commits on Jan 11, 2019
Commits on Jan 8, 2019
  1. v2v: -o openstack: Don't echo full commands (RHBZ#1664310).

    rwmjones committed Jan 8, 2019
    They can contain passwords or tokens if for example the
    ‘-oo os-password’ option is used.
    Thanks: Tomáš Golembiovský, Brett Thurber.
  2. Update copyright dates for 2019.

    rwmjones committed Jan 8, 2019
    This command run over the source:
    perl -pi.bak -e 's/(20[01][0-9])-2018/$1-2019/g' `git ls-files`
Commits on Jan 7, 2019
  1. Revert "launch: libvirt: Use qemu-bridge-helper to implement a full n…

    rwmjones committed Oct 2, 2014
    …etwork (RHBZ#1148012)."
    We've been carrying this exact patch in RHEL 7 for several years.  It
    reverts the change made in 2014 where we switched to using the virbr0
    bridge for libguestfs networking instead of SLIRP.  We thought SLIRP
    was going to become unsupported in qemu, but recently there have been
    more encouraging signs since it looks like SLIRP will be spun off as a
    separate project, running as a modular process and properly secured
    and supported.
    This reverts commit 224de20.
Commits on Dec 14, 2018
  1. v2v: windows: Add comment about possibility of removing GPO restricti…

    rwmjones committed Dec 14, 2018
    Although it may not be a good idea because usually they are installed
    for a reason.
Commits on Dec 12, 2018
  1. Version 1.39.14.

    rwmjones committed Dec 12, 2018
  2. lib: direct: Move serial option from -drive to -device.

    rwmjones committed Dec 12, 2018
    qemu deprecated and removed this option from the -drive parameter,
    resulting in:
      Block format 'raw' does not support the option 'serial'
    See also:
Commits on Dec 11, 2018
  1. Version 1.39.13.

    rwmjones committed Dec 11, 2018
  2. gnulib: Use https URL instead of git.

    rwmjones committed Dec 11, 2018
    This is apparently more secure (against MITM attacks), and furthermore
    Savannah git: access is broken at the moment.
  3. Version 1.39.12.

    rwmjones committed Dec 11, 2018
  4. tests: Provide a way for skipping tests/bigdirs/

    rwmjones committed Dec 11, 2018
    This test is currently broken because of a kernel bug
  5. tests: Fix console for slow tests on Ubuntu 18.04.

    rwmjones committed Dec 11, 2018
    Use the same fix as for Debian and Ubuntu 16.04.
Commits on Dec 7, 2018
  1. builder: Add a second archive repo to the virt-builder repos.

    rwmjones committed Dec 6, 2018 has almost run out of space.  I would like to
    move templates for older guests to the archive site (which is slower
    but has unlimited space).  The easiest way to do this is to add a
    second repo.
    This only affects obsolete/unsupported Fedora releases.
You can’t perform that action at this time.