Use PKG_CHECK_MODULES instead of AC_CHECK_LIB for libmagic #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this patch has too many problems to consider and the reporter has already solved this by installing libguestfs from RPMs, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in https://listman.redhat.com/archives/libguestfs/2021-May/msg00011.html.
With this change it is possible to get libmagic discovered from a non-standard prefix using e.g.
LIBMAGIC_LIBS="~/.local/lib64" LIBMAGIC_CFLAGS="-O3"(there may also be a way usingPKG_CONFIG_PATHthat I'm not aware of).Without this change discovery can be achieved with
LDFLAGS="-L ~/.local/lib64".Note the
magic.hheader file also needs to be discoverable, which I achieved usingCPPFLAGS="-I ~/.local/include".