Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Reparent IBusHangulEngine from IBusEngineSimple to handle Compose key. #54
The compose key fails to be interpreted in the latin mode of Ibus-Hangul which is annoying because when you set this feature, you expect it to work with every input (it works for instance with Ibus-Anthy in latin mode, which we often use sometimes when we write Japanese, though Ibus-Hangul is still our main engine).
In my home, we are 2 people who need to regularly write in Korean and in French (with accents, etc.), and while we could switch engines, we find it much easier to simply switch in and out of hangul mode and have compose key mapped on the keyboard (we use the X option 'compose:caps'). This used to work for years, up to Fedora 25 but stopped working since Fedora 26 and then 27. Ibus-Hangul apparently didn't change, but Ibus did and the developer said:
And the solution is that Ibus-Hangul needs to evolve as well. IBusEngineSimple handles key composition already so the solution is to reparent IBusHangulEngine and to delegate to the parent's process_key_event() when in latin mode.
This commit implements this improvement. I'm guessing it may actually improve other things as well by making good usage of the parent implementation for the latin mode, hence bringing consistency through all input and engines.