New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reparent IBusHangulEngine from IBusEngineSimple to handle Compose key. #54

Merged
merged 1 commit into from May 12, 2018

Conversation

Projects
None yet
2 participants
@Jehan

Jehan commented Jan 19, 2018

The compose key fails to be interpreted in the latin mode of Ibus-Hangul which is annoying because when you set this feature, you expect it to work with every input (it works for instance with Ibus-Anthy in latin mode, which we often use sometimes when we write Japanese, though Ibus-Hangul is still our main engine).

In my home, we are 2 people who need to regularly write in Korean and in French (with accents, etc.), and while we could switch engines, we find it much easier to simply switch in and out of hangul mode and have compose key mapped on the keyboard (we use the X option 'compose:caps'). This used to work for years, up to Fedora 25 but stopped working since Fedora 26 and then 27. Ibus-Hangul apparently didn't change, but Ibus did and the developer said:

The difference between Fedora 25 and Fedora 26 means, probably ibus no longer inherits gtk-im-context-simple but use IBusEngine only.

And the solution is that Ibus-Hangul needs to evolve as well. IBusEngineSimple handles key composition already so the solution is to reparent IBusHangulEngine and to delegate to the parent's process_key_event() when in latin mode.
(Cf. ibus/ibus#1976 (comment))

This commit implements this improvement. I'm guessing it may actually improve other things as well by making good usage of the parent implementation for the latin mode, hence bringing consistency through all input and engines.

Jehan
Reparent IBusHangulEngine from IBusEngineSimple to handle Compose key.
The compose key fails to be interpreted in the latin mode of
Ibus-Hangul which is annoying because when you set this feature, you
expect it to work with every input. IBusEngineSimple handles key
composition already so the solution is to reparent IBusHangulEngine and
to delegate to the parent's process_key_event() when in latin mode.
@Jehan

This comment has been minimized.

Jehan commented Apr 6, 2018

Hi @choehwanjin !
Any chance to see this fix merged so that various distributions relying on your repository would get the fix?
Thanks! :-)

@choehwanjin

This comment has been minimized.

Member

choehwanjin commented Apr 10, 2018

I will check it.
Thank you.

@choehwanjin choehwanjin merged commit ed9478a into libhangul:master May 12, 2018

@Jehan

This comment has been minimized.

Jehan commented May 13, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment