hooks: remove __attribute__((packed)) from struct bionic_file #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes struct size mismatch on aarch64 (used to be 144 vs 152 on Android), which resulted in crash of code using stdout/stderr symbols like fprintf(stderr, ...) found in MTK audio HAL.
krnlyng
approved these changes
Aug 24, 2020
mlehtima
approved these changes
Aug 24, 2020
|
Oh! This have might the magic bug we have been fighting for a while on arm64! Will try this out! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bionic does not have this attribute for struct __sFILE definition. Fixes struct size mismatch on aarch64 (used to be 144 vs 152 on Android), which resulted in crash of code using stdout/stderr symbols like fprintf(stderr, ...) found in MTK audio HAL.
Thanks to @krnlyng for noticing this.