Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten wiremesh caps when vertex on single edge. #999

Merged
merged 3 commits into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@twodee
Copy link

twodee commented Nov 7, 2018

In #963, I asked about flattening the caps on any terminal vertices of wiremeshes. Following @alecjacobson's implementation suggestions, I zero out the offset when a vertex is incident on only one edge.

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • Adds corresponding python binding.
  • This is a minor change.
@fwilliams
Copy link
Collaborator

fwilliams left a comment

Small cleanup task then it looks good to merge.

Show resolved Hide resolved include/igl/copyleft/cgal/wire_mesh.cpp Outdated

@fwilliams fwilliams merged commit 4856628 into libigl:dev Nov 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@twodee

This comment has been minimized.

Copy link
Author

twodee commented Feb 13, 2019

Fixes #963.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.