Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set watches on SMBFS filesystems. #8

Closed
wants to merge 1 commit into from

Conversation

arrowd
Copy link

@arrowd arrowd commented Apr 19, 2020

This is a workaround for PR 243836. I plan to open a PR to fix the core issue in SMBFS, too.

The behavior can be overridden with INOTIFY_FORCE_WATCH_SMBFS env var.

@wulf7
Copy link
Contributor

wulf7 commented Apr 20, 2020

It looks like you are trying to reimplement feature which is already existing. Try to rebuild libinotify with following option specified at configure stage: --enable-skip-subfiles=nfs,fusefs,smbfs

@arrowd
Copy link
Author

arrowd commented Apr 20, 2020

Not only it works, it also still report some changes for SMBFS mount!

Can I enable --enable-skip-subfiles=smbfs by default in devel/libinotify port?

@wulf7
Copy link
Contributor

wulf7 commented Apr 20, 2020

Can I enable --enable-skip-subfiles=smbfs by default in devel/libinotify port?

I do not know. I do not maintain it

@arrowd arrowd closed this Apr 20, 2020
@wulf7
Copy link
Contributor

wulf7 commented Apr 20, 2020

I recommend to add fusefs to this list too. Opening directory with e.g. photos triggers full directory content download on mtpfs which is painfully slow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants