Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix use_full_image==false case #365

Merged
merged 1 commit into from Jul 27, 2021

Conversation

jonsneyers
Copy link
Member

Some fixes to the case where the full modular image is skipped:

  • don't assume that everything happens at the modular AC group level (minShift==0), there can also be upsampling causing channels to have nonzero shift even when there's no Squeeze
  • for partial decodes (when zerofill is true), don't try to fill the full image when it's not used. Instead initialize the decoded image with zeroes and skip the decoding.

@jonsneyers jonsneyers added bug Something isn't working decoder Related to the libjxl decoder fuzzerbug Security/robustness bugs, not properly handling corrupt/malicious input labels Jul 26, 2021
lib/jxl/dec_modular.cc Outdated Show resolved Hide resolved
@deymo
Copy link
Contributor

deymo commented Jul 27, 2021

@jonsneyers please put the PR description in the commit message, you can do so manually when doing "Squash and merge" (which also tags the commit with the PR number).

@jonsneyers jonsneyers merged commit 1c05e11 into libjxl:main Jul 27, 2021
11 checks passed
@deymo deymo added the merge-0.5 PR label to flag PRs that need to be merged to v0.5.x label Jul 27, 2021
@deymo
Copy link
Contributor

deymo commented Jul 29, 2021

The code this is fixing was introduced in #205 which is not in v0.5.x branch, removing label. (use_full_image is not present in v0.5.x)

@deymo deymo removed the merge-0.5 PR label to flag PRs that need to be merged to v0.5.x label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working decoder Related to the libjxl decoder fuzzerbug Security/robustness bugs, not properly handling corrupt/malicious input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants