Skip to content
Browse files

[#18149087] (cleanup) Calling exit() from core modules

Not that these two exit() calls were reachable, anyway, since an
unconditional return is called just prior to each of them, but
exit() should never be called from a module. It's safe to call
it from a .pl script, but calling it from within a .pm causes
the Plack engine itself to exit, which is bad news.
  • Loading branch information...
1 parent 27c9ce5 commit 750216c09ad6bd9201cfa807549e8c8f3ff6e3f3 @ctfliblime ctfliblime committed Sep 19, 2011
Showing with 0 additions and 2 deletions.
  1. +0 −2 C4/Items.pm
View
2 C4/Items.pm
@@ -947,7 +947,6 @@ sub GetItemStatus {
}
$authvalsth->finish;
return \%itemstatus;
- exit;
}
else {
@@ -1047,7 +1046,6 @@ sub GetItemLocation {
}
$authvalsth->finish;
return \%itemlocation;
- exit;
}
else {

0 comments on commit 750216c

Please sign in to comment.
Something went wrong with that request. Please try again.