Permalink
Browse files

Bug 2524: improving the submitted test reports

switching from 'prove' to 'perl' to run the test scripts when we're preparing
them to be submitted to smolder. Prove adds an additional summary at the end
of the test run which confuses the TAP parser in smolder. It thinks that an
additional test has been run, and it fails it.

Then, I added a '-' before the command in the Makefile. THat's so that even
if 'perl' returns a failing code (because some tess failed), the rest of the
rules are run and a report gets submitted. Othewise, only passing reports
get sent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
  • Loading branch information...
1 parent 481929b commit daa2a042230a1d3a2f97fd9a6c4261b77bcbacc7 @amoore amoore committed with Galen Charlton Aug 15, 2008
Showing with 2 additions and 2 deletions.
  1. +2 −2 t/Makefile
View
@@ -106,6 +106,6 @@ $(SMOLDER_REPORT_TARBALL) :: $(SMOLDER_REPORT_FILENAME)
$(SMOLDER_REPORT_FILENAME) :: report
report :: config_file $(ZEBRA_CONF_FILES) $(SCRIPTS)
- KOHA_CONF=$(TEST_CONF_FILE) PERL5LIB=$(PERL5LIB) TEST_CLASS=$(TEST_CLASS) RUN_EXPENSIVE_TESTS=$(RUN_EXPENSIVE_TESTS) \
- $(PROVE) $(PROVE_FLAGS) $(TEST_FILES) > $(SMOLDER_REPORT_FILENAME)
+ -KOHA_CONF=$(TEST_CONF_FILE) PERL5LIB=$(PERL5LIB) TEST_CLASS=$(TEST_CLASS) RUN_EXPENSIVE_TESTS=$(RUN_EXPENSIVE_TESTS) \
+ $(PERL) $(TEST_FILES) > $(SMOLDER_REPORT_FILENAME)

0 comments on commit daa2a04

Please sign in to comment.