Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

[#16672179] internal server error on confirm checkout hold override

- fixed wrong way to get superlibrarian permission
- fixed namespace problem in Circulation.pm calling ModReserve
  • Loading branch information...
commit e33c7a91f8bad4532ac358f3e20607363fdef349 1 parent e12ff40
hgq hgq authored
Showing with 3 additions and 3 deletions.
  1. +2 −2 C4/Circulation.pm
  2. +1 −1  circ/circulation.pl
4 C4/Circulation.pm
View
@@ -1109,7 +1109,7 @@ sub AddIssue {
if (($resbor eq $borrower->{'borrowernumber'}) || ($howReserve eq 'fill')) {
if ($howReserve eq 'requeue') {
if ($$res{priority} == 0) {
- ModReserve(1,$res->{'biblionumber'},
+ C4::Reserves::ModReserve(1,$res->{'biblionumber'},
$res->{'borrowernumber'},
$res->{'branchcode'},
undef, ## $res->{'itemnumber'},
@@ -1130,7 +1130,7 @@ sub AddIssue {
## FIXME: requeue as bib-level hold is temporary until we get
## a permanent fix for retaining bib- or item-level hold
if (($$res{priority}==0) || ($$res{found} ~~ 'W')) {
- ModReserve(1,$res->{'biblionumber'},
+ C4::Reserves::ModReserve(1,$res->{'biblionumber'},
$res->{'borrowernumber'},
$res->{'branchcode'},
undef, ## $res->{'itemnumber'},
2  circ/circulation.pl
View
@@ -192,7 +192,7 @@ sub FormatFinesSummary {
if ($query->param('reserve_confirmed')) {
my $perm = C4::Auth::haspermission(C4::Context->userenv->{id}, {superlibrarian => 1});
- if ($$perm{superlibrarian}) {
+ if ($perm) {
$issueconfirmed = 1;
}
elsif (C4::Context->preference('DisableHoldsIssueOverrideUnlessAuthorised')) {
Please sign in to comment.
Something went wrong with that request. Please try again.