Permalink
Browse files

minor tweaks:

- suppress Perl warning of uninit var in numeric comparison of
  $lasttime when there isn't any (maybe we logged out properly?)
- Plack eval()'s expect clean exits, so installer.pl was backwards
  and never reached login page after Web installation step 3,
  cannot exit nonzero
  • Loading branch information...
1 parent 3f67c4d commit f8e1e67bc0894a0817e042adc083f837ea1aae1b @hgq hgq committed Jul 22, 2011
Showing with 3 additions and 3 deletions.
  1. +1 −1 C4/Auth.pm
  2. +2 −2 installer/install.pl
View
@@ -601,7 +601,7 @@ sub checkauth {
C4::Context::set_shelves_userenv('tot',$session->param('totshelves'));
$debug and printf STDERR "AUTH_SESSION: (%s)\t%s %s - %s\n", map {$session->param($_)} qw(cardnumber firstname surname branch) ;
$ip = $session->param('ip');
- $lasttime = $session->param('lasttime');
+ $lasttime = $session->param('lasttime') || 0;
$userid = $session->param('id');
$sessiontype = $session->param('sessiontype');
}
View
@@ -268,7 +268,7 @@
# we have finished, just redirect to mainpage.
#
print $query->redirect("/cgi-bin/koha/mainpage.pl");
- exit 1;
+ exit;
}
elsif ( $op && $op eq 'finish' ) {
$installer->set_version_syspref();
@@ -476,7 +476,7 @@
my ($version) = $rq->fetchrow;
if ($version) {
$query->redirect("install.pl?step=3");
- exit;
+ exit;
}
}
}

0 comments on commit f8e1e67

Please sign in to comment.