If there's more than one proxy standing between the client and Koha's web server, the HTTP_X_FORWARDED_FOR header may contain more than one IP address. C4::Branch::GetBranchByIp was not prepared for this condition, and it would cause an exception. There are also some proxies which insert a non-IP value into the HTTP_X_FORWARDED_FOR header (e.g. "unknown") to protect privacy or who knows why. This would bunge up Koha's IP detection. This patch looks for something that looks like a good address, then if all else fails it resorts to reporting that the client is not in any branch.
Ports over academic codeline ability to include runtime parameters -- see commit 831ba60 in academic code. Adds the ability to use parameters in the SQL using __PARAMETER_NAME__ and will prompt the person running the report to provide values.
Pt21556717 04 08
…colon_4_08 21 04 pt15656343 installer stray semicolon 4 08
21 03 installer isuppress 4 08
Net::CIDR::Compare has buggy output with complaints about an invalid DESTROY method. Replacing it with Net::IP to eliminate concern that this could cause issues.
Sip cr fix 04 08
This section should just trim whitespace from the ends of the barcode, not remove all whitespace altogether.