Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Sep 26, 2011
  1. @hgq
Commits on Aug 18, 2011
  1. @dlbptfs

    PT17093249: Call to deprecated routine ModReserveFillCheckout in SIP2

    dlbptfs authored
    Reserves::ModReserveFillCheckout was removed from the API.  Removed the
    SIP call to this subroutine and cleaned up a few other references to
    ModReserveFill which has also been deprecated.
Commits on Jul 12, 2011
  1. @ctfliblime
Commits on Jul 1, 2011
  1. @ctfliblime
Commits on Jun 17, 2011
  1. @ctfliblime
Commits on Jun 16, 2011
  1. @ctfliblime
Commits on Jun 9, 2011
  1. @ctfliblime

    Add and include it universally

    ctfliblime authored
    At this point all we're doing is turning on warnings, strict,
    and 5.10 features by default in all files. This also defines
    a $Koha::VERSION variable which is going to be the basis for
    the code revision number, as opposed to $C4::Context::VERSION,
    which is the data config version number.
Commits on Jun 6, 2011
  1. @hgq

    [Fixes #13859777] Picking up hold item at different location

    hgq authored
    - deprecated AddIssuingCharge()
    - fix metaphysical confusion of item's physical location: upon checkout, remove
      from branchtransfers and tmp_holdsqueue (did in renewal)
    - show waiting reserves cancelled before they expire in Holds Shelf Action
    - repurposed syspref reservesNeedConfirmationOnCheckout into pipe-delimited list
      to handle combos: same|diff patron, pending|intransit|waiting, sameitem|
Commits on Jun 2, 2011
  1. @hgq

    effort to fix cumbersome behavior of circulation affecting fines,

    hgq authored
    holds, transfers, item status, checkin, checkout.  addresses 12895645,
    13284525, 13229501, 13390195 and unreported bugs.
    - manual transfer via circ Transifers, item is already
      at destination library and/or duplicate rows in branchtranfers, one of
      them Wrong: allow manual reroute by cancelling previous transfer, cannot
      transfer twice, cannot transfer dest=curr, grep out curr branch from
      pulldown menu of destinations.
    - claims returned, returned by a different patron
    - overdue (notlost): refuse return, backdate returndate lt issuedate
    - allow spoofing today's date in as a cmdline argument
    - backdate to no longer max, so remove 'max overdue' verbiage
    - overdue charge is per circ cycle based on due date
    - show item "lost by [borrower]" in
    - fix lost by different patron upon checkout, gets credit (zero outstanding)
      regardless claims returned, autoremoved from that patron's Lost Items
    - handle wrong workflow: notlost->claims returned: no link between patron
      and item, don't create one.  prompt that updateitem failed.
    - obscure one-time bug: lost, change syspref to MarkLost..=ON, set to notlost, error: line 625
    - tweak fines log
    - append "due on [datedue]" in description to grep upon
    - overdue was not being charged at checkin when cron isn't running
    - bogus SQL statement was zeroing out both amount and amountoutstanding, should be
      only amountoutstanding
    - add a line of overdue forgiven to patron account for exemptfine
    - refund owed, give refund total balance, need append ' issued at no.[accountno]'
    - append ', paid at no.[accountno]' in recordpayment() and makepayment() so we can
      pass regex or RLIKE to handle refund owed on charges, not just lost returned
    - handle 4 varieties of payments: full lineitem, partial lineitem, full dispersal,
      partial dispersal
    - don't display overdue red text if not overdue after backdate recalc.  Fix issue's
      overdue key to use returndate instead of today
    - fines resulted in impossible set of amount=1.25 and outstanding=2.50.  fix is to
      adjust both fields and append text of "adjusted backdate returned [returndate]"
    - don't charge it not overdue, don't zero out
    - overdue accruals are adjusted due to backdate checkin
    - swap precedence of issuingrule max_fine vs. syspref MaxFine.  issuingrule supercedes.
      max overdue is a threshold, not a separate charge
    - calculate overdues upon item status change (nocron) or MarkLost..toggled
    - don't autocharge max overdue if not maxed
    - waslost+claims returned: use authorised vlaue 1 in category LOST for claims returned
      undo. when changing from Lost to Claims Returned in catalogue, don't autocheckin
      if ML=0, don't remove.  make claims returned lookup old issues if ML=1.  item was
      unlinked from patron account. in chargelostitem, lookup lost in lost_items instead
      of issues.  lost now found at checkin, refund if applicable.  don't autorefund upon
      ->notlost if never paid.
    - checkin w/ hold priority, not lost, upon ignore hold do not autoset to Waiting
    - process lost (and unlink from patron account) and hold together if have both
    - auto cancel transfer if it was intransit from A to B but checked out at A
    - item homebranch is B, checked out at A, no holds pending, checked in A: either
      confirm was in transit or cancel transfer and keep at A, or initiate transfer to B
    - at pickup branch checkin, differentiate b/w hold to pull b/c was intransit from
      hold already waiting
    - wonky superlibririan activity: hold waiting at pickup branch A but tries to checkin
      at branch B: confirma dn transfer to A, or requeue and keep at B
    a lot more to go
Commits on May 10, 2011
  1. @hgq @ctfliblime

    [Fixes #12950597 cancel or requeue reserve

    hgq authored ctfliblime committed
    * don't prompt for username and passowrd authorization for superlibrarian
    * allow option to re-enqueue or cancel reserve
    * handle reserve even if it's a renewal
    * changed parameters to C4::Circulation::AddIssue() from flat list to
      associative array
    * fixed tags in circulation.tmpl
    * fixed sanity check in for Koha installer user who
      doesn't have a branch set
    * make offline circ script send requeue param for holds
Commits on Mar 21, 2011
  1. @ctfliblime
Commits on Mar 12, 2011
  1. @ctfliblime
Commits on Mar 7, 2011
  1. @pjones9
Commits on Mar 2, 2011
  1. @pjones9
  2. @pjones9

    Test updates

    pjones9 authored
Commits on Feb 28, 2011
  1. @hgq @pjones9

    first partial commit for PTFS PT 8625217 CIRC 1124 fines

    hgq authored pjones9 committed
    replaced C4::Members::GetMemberAccountRecords() with
    C4::Accounts::MemberAllAccounts(), with uses hash params.
    Optional total_only param is for SQL efficiency.  Previoulsy,
    if you wanted just the total amountoustanding, GetMember..()
    would do the entire list of account records.
    separated out title, barcode, biblionumber for records with
    an itemnumber.  The title and barcode are no longer part of
    the description, an effort to standardize the display.
    standardized description for ForgiveFineForClaimsReturned()
    and chargelostitem().
    added C4::Items::MapBibs2Items() for efficiently getting a
    one-time lookup of biblionumbers in batch given an array of
    itemnumbers.  This sub was designed to be called outside of
    a loop so that the huge JOIN doesn't occur on each item.
    manualinvoice() completely refactored.
    added No. (accountno) and Title (w/ barcode) columns to patron
    Fines tab.
    - need to check that all displays are standardized.
    - lost item, damaged, &c. should be Refund, not Payment
    - fix UI mandatory fields checking
    - credit transactions need to refer to accountno credited upon,
      eg 'Pay' in UI
Commits on Feb 16, 2011
  1. @pjones9

    PT 9613381: Add support for season in periodical chronologies

    pjones9 authored
    Creates new class, C4::Model::Periodical::Chronology, which is
    a subclass of DateTime::Format::Strptime and replaces calls to
    DateTime::set_formatter to be set with the new subclass. Access
    seasons in the pattern by specifying %q/%Q to get the season
    for the northern/southern hemisphere.
Commits on Feb 8, 2011
  1. @hgq @pjones9

    PTFS PT 5915961 search barcode by suffix

    hgq authored pjones9 committed
    * Added for patrons and items, also attempts to handle edge case of multiple
      branches w/ same suffix but different prefixes
    * Incidental fixes: refactored tools/ to work under strict;
      patron multifield advanced search w/ no results breaks HTML display b/c
      search on borrowernumber w/ no results still assumes a borrower and was
      displaying side tabs; no bib record for field() w/out proper itemnumber in; refactored Circulation::barcodedecode() to accept hash
      params; incorrect dupecheck on nonexistent barcode in
Commits on Nov 29, 2010
  1. @pjones9

    Replace "Serials" with "Periodicals"

    pjones9 authored
    SCLS-SER-1027 - Adjust prediction when editing enumeration and chronology
    SCLS-SER-1029 - Adding chronologies to issue prediction
    SCLS-SER-1030 - Managing Subscriptions Centrally
    SCLS-SER-1033 - Multiple agencies with separate subscriptions
Commits on May 5, 2010
  1. @colinsc

    Add Ability to batch delete items

    colinsc authored J. David Bavousett committed
    NB updatedatebase needs a correct DB Version setting
    There is no check on whether deleted items have transactions or are the last item
    in this it reflects the underlying routines
    Possible TBD allow remove of individual rows from the delete batch
     (there is a method in ItemDeleteList )
    User interaction could be enhanced
Commits on Sep 29, 2009
  1. @gmcharlt

    Delete unused function

    Nahuel ANGELINETTI authored gmcharlt committed
    Signed-off-by: Galen Charlton <>
Commits on Sep 16, 2009
  1. @gmcharlt

    Bug 2500 Correcting incorrect splitting of cutter numbers

    Chris Nighswonger authored gmcharlt committed
    This patch does two things to improve the call number splitting algorithms:
    1. It makes changes to ensure that cutter numbers are split correctly in ddcns
    2. It moves custom/fiction/biography call number splitting to a separate algorithm.
        Before they were incorrectly placed in ddcns.
    This patch also modifies the call number splitting tests to accept call numbers from the
    command line to allow quick testing of any give call number against a particular algorithm.
    Signed-off-by: Galen Charlton <>
Commits on Sep 15, 2009
  1. @gmcharlt

    updated DB-dependent tests to reflect labels rewrite

    gmcharlt authored
    * removed lib/KohaTest/, which is now completely outdated
    * updated list of database tables to truncate in lib/
    Signed-off-by: Galen Charlton <>
Commits on Sep 6, 2009
  1. @gmcharlt

    replace syslog with warns

    gmcharlt authored
    As discussed with Chris Nighswonger on #koha, this patch
    removes the calls to syslog and replaces them with warns
    so that error messages generated by the labels code
    are sent to the Apache error log.  This avoids splitting
    this sort of logging across multiple files and is consistent
    with current practice in most of the rest of Koha.
    Signed-off-by: Galen Charlton <>
Commits on Sep 1, 2009
  1. [38/40] Misc bugfixs

    Chris Nighswonger authored
  2. [35/40] Work on C4::Labels tests and various bugfixs resulting

    Chris Nighswonger authored
    This patch also moves the Labels tests into their own sub directory.
    Due to a squash mistake this patch also includes the following:
    Fixing up POD for C4::Labels modules
    Also a minor bugfix and code refactoring.
  3. [3/40] Work on C4::Labels::Profile module and tests

    Chris Nighswonger authored
  4. [2/40] Work on C4::Labels::Template and associated tests

    Chris Nighswonger authored
    This commit also contains some work on C4::Labels::Layout as well
  5. [1/40] Work on C4::Labels::Layout module and tests

    Chris Nighswonger authored
    NOTE: This patch is the first of 40 which almost completely re-factor the
    label creator code into a hopefully more scalable form. The new format is
    a move in direction of OO handling labels, batches, templates, layouts, and
    profiles as objects thus permitting easier implementation of features and
    enhancements. It should be possible to export label data in any format one
    might choose with the simple addition of a script similar to those included
    which produce pdf, csv, and xml format.
    One of the larger improvements is a change in workflow that results in template,
    layout, and start label selection occurring just before export.
    There are also various bugfixes and smaller interface improvements woven into it.
    It should be noted that this patch series removes the patron card creator feature
    for the present. This feature was only partially completed. A completed variation
    will be submitted as a separate patch series to follow in the near future.
    The following bugs and enhancements are fixed by this series of patches:
    2944 Search to add items to a label batch broken
    2061 labels_conf DB values: NULL vs. 0
    2511 CSV format string is not cleared when unselected in the label layout editor
    2515 Re-factor C4::Labels::DrawSpineText
    2823 Label Generator not generating barcodes
    3171 Problem due to internationalization in label-create-template.tmpl in de-DE and possibly others
    3180 Active settings for label settings should be set at print time only
    This work was sponsored by Foundations Bible College & Seminary, Dunn, NC USA
Commits on Aug 11, 2009
  1. @gmcharlt

    bug 2157: add ability to 'clean' staged record batches

    gmcharlt authored
    batches, it is now possible to 'clean' a batch by
    removing all bib and item records staged in the batch.  This
    has the effect of helping to reduce database space used
    by old import batches as well as removing staged records
    from the cataloging reservoir search.  Note that 'cleaning'
    a batch affects only the copies of the records that were staged;
    if the batch was committed, cleaning the batch does not
    affect any bibs and items that were committed into the catalog.
    Also note that once you clean a committed batch of records, it is
    impossible to undo the previous commit operation.
    Signed-off-by: Galen Charlton <>
Commits on Jul 30, 2009
  1. bug 3435: AddReturn overhaul.

    Joe Atzberger authored Galen Charlton committed
    Required for SIP checkin implementation, but also for internal correctness.
    AddReturn had too many things going on, with no guarantee of data being
    available for the later calls.  At some point we started tacking on all the
    branch transfer logic without testing edge cases.  In particular, $borrower
    is not checked to be sure it is defined, considering the item may not have been
    checked out so no borrower would be associated.  That means that CircControl
    of "PatronLibrary" would be inaccurate, Circ Alerts will be totally confused
    (untargeted), and the Fix... subs would fail.
    Note that *many* errors are still present in _FixAccountForLostAndReturned, including
    those where comments are added, such that it might behave strangely even with $borrower.
    Renamed the internal subs with leading underscore, per convention.  Changed
    the arguments to be scalars when only scalars are needed, not entire objects.
    Added depth to WrongBranch message that includes Rightbranch.
    Signed-off-by: Galen Charlton <>
Commits on Jun 9, 2009
  1. removing disused C4::Serials functions

    Galen Charlton authored
    The following functions are no longer in use:
    * old_newsubscription
    * old_modsubscription
    * old_getserials
    Signed-off-by: Galen Charlton <>
Commits on Jun 8, 2009
  1. bug 3314: remove disused scripts and API functions

    Galen Charlton authored
    The distributedto column of the subscription table is
    no longer used, having been replaced by the serials
    routing list table.  This patch removes two C4::Serials
    functions and a script and template, none of which were
    reachable by current code:
    Signed-off-by: Galen Charlton <>
  2. bug 3303: removed references to news_channels*

    Galen Charlton authored
    Removed routines in C4/ that refered
    to missing database tables news_channels and news_channel_categories.
    Signed-off-by: Chris Cormack <>
    Signed-off-by: Galen Charlton <>
  3. bug 3302: removed disused references to opac_electronic

    Galen Charlton authored
    Removed routines in C4/ that refer to
    a missing opac_electronic table.
    Signed-off-by: Chris Cormack <>
    Signed-off-by: Galen Charlton <>
Something went wrong with that request. Please try again.