Using the individual Edit links from the patron details display was inappropriately updating an existing expiration date; fixes that so the field is only updated when a new record is created.
The variable for search groups was not being passed to the staff advanced search template, so the page never showed search group options. Added the variable and also reworded both staff and OPAC pulldown defaults from "All categories" to "All library search groups" (or "All libraries" in the OPAC masthead) for clarity.
If an item was checked out and deleted without being checked in, a null itemnumber in the issues table made the fines script stop processing without any alerts. Any entries in the issues table after the orphaned record did not accrue fines. This adds a fix to skip entries with null itemnumbers.
…ng queue The routines for picking available items to fill reserves was not checking the CircControl value to constrain its pool of potential items.
If both the circ rule and the MaxFine syspref had values for maximum fine, the system was applying the lesser. This meant that in some cases the circ rule value was not being used (for example, a circ rule max fine of $10 but a syspref of $5). Modifies the code so that if the circ rule has a value for max fine, that value is used regardless of the syspref contents.
Advanced search collection code searches were using mc-itemtypes as the index; fixed script to use proper index (mc-ccode) and also fix display row/column counts.
Fixes problem of multi-page reports using parameters not paginating properly.
Fixes problem of one item with non-holdable otherstatus blocking OPAC holds on other available items on the title.
Converting to cents also yields inexact sums in some circumstances, causing accounts to show up with erroneous $0.01 paid amounts. Instead, we'll just compare floats but do so in a manner that accounts for their imprecision.
Cart hold link was missing in default view, but visible in More Details view; this makes it visible in default view.
The inventory selection for item type was calling biblioitems.itemtype, which comes from the 942$c field and frequently doesn't have data entered. This changes it to use the item record's item type field.
Relying on exact comparisons of floating point values will always result in a certain percentage of errors. This patch fixes some of these error points by instead relying on integer comparison or expanding the range of the FP comparison.
The OPAC Reading History tab has options to display all or last 50 entries, and to sort by Title (if sorted, sort back by date). However, sorting by Title/Date ignored the display all selection, and only used the last 50 entries. This makes the sorts obey the limit parameter. Note that if the limiter is last 50, the list returned will be different depending on whether title or date is sorted. If by title, the selection is alpha; if by date the selection is most recent 50.
The Most Circulated Items report wizard was basing item type selection on biblioitems.itemtype, not the item record's item type. Since most sites don't fill in the 942$c (mapped to biblioitems.itemtype), results weren't valid. Changed script to use items.itype instead.
Fixes problem with error saving patron edits if dateofbirth is in BorrowerMandatoryField.
The patron account update page from the OPAC wasn't sending a changed email address as part of the message; fixed.
Trying to download a starter patron load .csv file was producing an error; this fixes the problem.
HOLD_CANCELLED, HOLD_EXPIRED, CHECKIN, and CHECKOUT notices were defaulting to the 'from' address in the KohaAdminEmailAddress syspref. This updates the code to check for an email address in the branch policy, and only use the syspref as a fallback; needed for consortia with separate library policies and controls.
This reverts commit 1db784f.
check_cookie_auth and check_api_auth will delete the user's whole session if they fail a permissions check. This is a little heavy handed, and it makes certain permissions structures impossible. This commit refactors check_cookie_auth completely and removes the session deletion section from check_api_auth.
This changes the TalkingTech message enqueueing such that new message entries get added to a database table rather than written to the filesystem. Also provides a new cron job that emits the pending entries as a single ttech-formatted string, marking the queue done in the process.
…t and adult audience.