Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Sep 30, 2011
  1. @hgq
Commits on Sep 19, 2011
  1. @ctfliblime

    Merge pull request #185 from hgq/15_06_pt18149087_4_08

    ctfliblime authored
    15 06 pt18149087 4 08
Commits on Sep 14, 2011
  1. @hgq
Commits on Sep 7, 2011
  1. @hgq

    [#17944127] semicolon in migrated data description field of accountlines

    hgq authored
    broke form post.  actually, any bizarre character.  solution: escape with
    javascript before submitting the form.  later on, fetch the accountline
    straight from the database, since we have to loop through it anyway to
    draw the refund tab.  There was a Firefox bug with hitting the back
    button that encoded stuff twice.  We just toss the form info of the
    accountline and use the database instead.
Commits on Aug 29, 2011
  1. @hgq
Commits on Jun 24, 2011
  1. @ctfliblime

    Eliminate INIT sections from modules

    ctfliblime authored
    INIT doesn't work with Plack::App::CGIBin. The way these
    are being used isn't necessary, anyway.
    Also clean up use of some package variables and warnings.
Commits on Jun 21, 2011
  1. @ctfliblime

    Merge pull request #38 from dlbptfs/PT13106067

    ctfliblime authored
    PT13106067: Pioneer creating child patron doesn't follow user's branchcod
  2. @ctfliblime
Commits on Jun 17, 2011
  1. @dlbptfs

    PT13106067: Pioneer creating child patron doesn't follow user's branc…

    dlbptfs authored
    Minor change to default value when a person of category type 'C' is added.
  2. @ctfliblime
  3. @ctfliblime

    Merge pull request #33 from hgq/06_05_pt13590281_head

    ctfliblime authored
    [on the way towards PT#13590281] some fault tolerance in holds
  4. @ctfliblime

    Merge pull request #29 from hgq/06_02_pt14438801_head

    ctfliblime authored
    [Fixes #14438801] writeoff amount outstanding instead of amount,
  5. @hgq @ctfliblime

    [Fixes #14321287] pass thru Context and Auth before calling GetMember()

    hgq authored ctfliblime committed
    to get logged in branch
Commits on Jun 16, 2011
  1. @ctfliblime

    De-globalize $dbh in C4::VirtualShelves

    ctfliblime authored
    The package global assignment of $C4::VirtualShelves::dbh, in
    addition to being just plain shoddy, is not persistence-safe. It
    also demands a database connection at module load time, which is
    a dependency we need to avoid both for testing and for the Plack
    localization middleware.
    This also removes a couple of other stray $dbh initializations
    and other cruft in other files.
Commits on Jun 15, 2011
  1. @dlbptfs

    PT14555597: ASCC sandbox error with patron batch edit

    dlbptfs authored
    There was a database error being thrown from Members::ModMember
    because the staff borrowernumber was not being passed from
    members/  Fixed this by using C4::Context->userenv->{number}
    in ModMember.
  2. @hgq

    [on the way towards PT#13590281] some fault tolerance in holds

    hgq authored
    - save a hit to the database in ModReserveStatus(), since we already have
      a complete reserve hash
    - deprecate UI notice for W and T in GetHoldsQueueItems(), nuke those from
      queue in-place
    - reset expiration upon requeuing hold in ModReserve()
    - fix comma-splice in FillReserve() when asserting an itemnumber.  The
      itemnumber can change in the case librarian allows override at checkout
      when item is same bib but not the item selected
    - cheaper hits to datatabase in ModReserveAffect()
    - if we keep checking in item w/ hold transfer, circumvent wrongtransfer:
      first time set to intransit, subsequent times catch that it's already in
    - reverse order by priority of additional bib checking in CheckReserves()
Commits on Jun 14, 2011
  1. @ctfliblime
  2. @ctfliblime
Commits on Jun 13, 2011
  1. @hgq

    [Fixes #14438801] writeoff amount outstanding instead of amount,

    hgq authored
    this allows combo w/ payment &c.  also, fix total due display in pay tab
Commits on Jun 9, 2011
  1. @ctfliblime

    Add and include it universally

    ctfliblime authored
    At this point all we're doing is turning on warnings, strict,
    and 5.10 features by default in all files. This also defines
    a $Koha::VERSION variable which is going to be the basis for
    the code revision number, as opposed to $C4::Context::VERSION,
    which is the data config version number.
Commits on Jun 3, 2011
  1. @ctfliblime
Commits on Jun 2, 2011
  1. @hgq

    effort to fix cumbersome behavior of circulation affecting fines,

    hgq authored
    holds, transfers, item status, checkin, checkout.  addresses 12895645,
    13284525, 13229501, 13390195 and unreported bugs.
    - manual transfer via circ Transifers, item is already
      at destination library and/or duplicate rows in branchtranfers, one of
      them Wrong: allow manual reroute by cancelling previous transfer, cannot
      transfer twice, cannot transfer dest=curr, grep out curr branch from
      pulldown menu of destinations.
    - claims returned, returned by a different patron
    - overdue (notlost): refuse return, backdate returndate lt issuedate
    - allow spoofing today's date in as a cmdline argument
    - backdate to no longer max, so remove 'max overdue' verbiage
    - overdue charge is per circ cycle based on due date
    - show item "lost by [borrower]" in
    - fix lost by different patron upon checkout, gets credit (zero outstanding)
      regardless claims returned, autoremoved from that patron's Lost Items
    - handle wrong workflow: notlost->claims returned: no link between patron
      and item, don't create one.  prompt that updateitem failed.
    - obscure one-time bug: lost, change syspref to MarkLost..=ON, set to notlost, error: line 625
    - tweak fines log
    - append "due on [datedue]" in description to grep upon
    - overdue was not being charged at checkin when cron isn't running
    - bogus SQL statement was zeroing out both amount and amountoutstanding, should be
      only amountoutstanding
    - add a line of overdue forgiven to patron account for exemptfine
    - refund owed, give refund total balance, need append ' issued at no.[accountno]'
    - append ', paid at no.[accountno]' in recordpayment() and makepayment() so we can
      pass regex or RLIKE to handle refund owed on charges, not just lost returned
    - handle 4 varieties of payments: full lineitem, partial lineitem, full dispersal,
      partial dispersal
    - don't display overdue red text if not overdue after backdate recalc.  Fix issue's
      overdue key to use returndate instead of today
    - fines resulted in impossible set of amount=1.25 and outstanding=2.50.  fix is to
      adjust both fields and append text of "adjusted backdate returned [returndate]"
    - don't charge it not overdue, don't zero out
    - overdue accruals are adjusted due to backdate checkin
    - swap precedence of issuingrule max_fine vs. syspref MaxFine.  issuingrule supercedes.
      max overdue is a threshold, not a separate charge
    - calculate overdues upon item status change (nocron) or MarkLost..toggled
    - don't autocharge max overdue if not maxed
    - waslost+claims returned: use authorised vlaue 1 in category LOST for claims returned
      undo. when changing from Lost to Claims Returned in catalogue, don't autocheckin
      if ML=0, don't remove.  make claims returned lookup old issues if ML=1.  item was
      unlinked from patron account. in chargelostitem, lookup lost in lost_items instead
      of issues.  lost now found at checkin, refund if applicable.  don't autorefund upon
      ->notlost if never paid.
    - checkin w/ hold priority, not lost, upon ignore hold do not autoset to Waiting
    - process lost (and unlink from patron account) and hold together if have both
    - auto cancel transfer if it was intransit from A to B but checked out at A
    - item homebranch is B, checked out at A, no holds pending, checked in A: either
      confirm was in transit or cancel transfer and keep at A, or initiate transfer to B
    - at pickup branch checkin, differentiate b/w hold to pull b/c was intransit from
      hold already waiting
    - wonky superlibririan activity: hold waiting at pickup branch A but tries to checkin
      at branch B: confirma dn transfer to A, or requeue and keep at B
    a lot more to go
Commits on May 27, 2011
  1. @kylemhall @ctfliblime

    SCLS-CIRC-2200-1 - Receipt Templates - BugFix - Set UseRecieptTemplat…

    kylemhall authored ctfliblime committed
    …es template var in various scripts.
Commits on May 3, 2011
  1. @hgq @ctfliblime

    [fixes #12373863] need edit_borrowers permission for Lost Items tab,

    hgq authored ctfliblime committed
    previous remaining_borrower[sic] permission is legacy found in LEK
  2. @kylemhall @ctfliblime

    SCLS-CIRC-2200-1 - Receipt Templates - Remove special fines receipt p…

    kylemhall authored ctfliblime committed
    …rint button, add to
Commits on Apr 27, 2011
  1. @dlbptfs @ctfliblime

    Work in Progress commit dealing with the creation of TalkingTech MESS…

    dlbptfs authored ctfliblime committed
    …AGE file.
    This is a temporary commit to see how things look in a ultra-busy
    circulation environment.
Commits on Apr 20, 2011
  1. @ctfliblime
Commits on Apr 19, 2011
  1. @hgq @ctfliblime

    PTFS PT 12341631 patron Lost Items was missing search header

    hgq authored ctfliblime committed
Commits on Apr 17, 2011
  1. @ctfliblime
Commits on Apr 15, 2011
  1. @hgq @ctfliblime

    PTFS PT 12004237 borrower wasn't being passed upon item transfter

    hgq authored ctfliblime committed
    in checkin.  This patch mostly refactors fines writeoff mechanism,
    moving functionality into C4::Accounts
Commits on Apr 13, 2011
  1. @ctfliblime
Commits on Apr 4, 2011
  1. @ctfliblime

    [Fixes 10710191] Patron Record Ownership

    ctfliblime authored
    This feature should have no functional effect for superlibrarians.
    This feature also has no functional effect if there are no
    categories defined under the "Patrons" category type.
    Once there is at least one of those categories is created,
    view/modify constraints go into effect. As described in the spec,
    staff will be able to work with patrons who are 1) members of their
    branch or 2) members a branch which is belongs of one or more of
    the same "patrons"-type branch categories as the active staff
    member's branch.
    This work completed as per the Pioneer "Patron Record Ownership"
  2. @hgq @ctfliblime

    PTFS PT 11662945 lost item and no unlink from patron account

    hgq authored ctfliblime committed
    This patch addresses the bizarre case of librarian clicking No,
    do NOT remove from patron's account when checking in a lost item.
    * removed refundlostitemreturned() and ForgiveFineForClaimsReturned(),
      refactored into makeClaimsReturned() for toggling on/off and crediting
      account and, if applicable, owing refund on payment made
    * tweaked AddReturn() to separate lost_items table from items.itemlost
    * the dialogue message for "Item lost, now found.. remove from.." now
      specifies the patron who's linked to the lost item regardless whether
      it's the same or different from the checkin issued patron
  3. @hgq @ctfliblime

    PTFS PT 11729705 refund or not upon lost item returned

    hgq authored ctfliblime committed
    This patch enhances a previous commit that automatically refunded
    for lost item return.  Here, we handle cases where refund is not
    justified; patron simply gets the credit for returning the lost item.
    * make payment and writeoff amounts a negative number
    * more explicit description in RCR2REF() to distinguish btw refund
      owed and refund issued
    * make refund on account balance for payments more generic
    * zero out all amounts outstanding upon refund account balance
    * handle case of lineitem writeoff, so no refund
    * handle case of payment (partial or full), lineitem or dispersal
      type.  any payment applied directly to item gets a refund, but
      whether or not patron ultimately receives money out of the refund
      is determined by overall account balance (which must be negative)
Commits on Mar 23, 2011
  1. @hgq @ctfliblime

    PTFS PT 11083279 CIRC-1118 refunds

    hgq authored ctfliblime committed
    This deals mostly with a lost item where the patron made a payment
    on a lost item that has been returned.  Actually, the patron is
    credited for the return, but since a payment was made, money needs
    to exchange hands beyond the abstract negative number of a credit
    on the account, if any.  Overall, the process was totally broken:
    checkout, marked lost, paid for lost, returned, credited with
    lost item returned... now refund on payment/credit--in that order,
    sortof.  Currently, there are no other types of refunds where
    money would exchange hands.
    * Temporary fix for duplicate rows in Pay Fines display.  Needs a
      permanent fix.
    * Corrected humpcase on MaxFine in C4::Overdues::CalcFine().
    * Forgot to pass param total_only in C4::Circulation::CanBookBeIssued().
    * Only charge max overdue if it's actually overdue.
    * Show Refund tab consistently no matter which Fines tab we're in.
    * Standardized description for Lost Item Returned.
    * Added param notmanual to C4::Accounts::manualinvoice().
    * Tested w/ superlibrarian authorization.
    Incidental fix not related to this PT.
    * Only set priority=-1 in old_reserves table for lapsed holds.
Something went wrong with that request. Please try again.