Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on May 4, 2010
  1. @gmcharlt

    start of release notes for 3.2

    gmcharlt authored
    NOTE: this is not exhaustive; please send me additions for
    features you have written.
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  2. @gmcharlt

    fix various errors reported by xt/author/translatable-templates.t

    gmcharlt authored
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  3. @gmcharlt

    copy new NPL icons from OPAC to staff

    gmcharlt authored
    Fixes problem found by xt/author/icondirectories.t
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  4. @gmcharlt

    fix template structure error found by xt/author/valid-templates.t

    gmcharlt authored
    Also fixed XHTML validity error
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Commits on May 3, 2010
  1. @nengard @gmcharlt

    bug 4442 rename batch edit tools

    nengard authored gmcharlt committed
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  2. @colinsc @gmcharlt

    Bug 4151 - Add DateTime to Perl dependencies

    colinsc authored gmcharlt committed
    Used in Sip.pm
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  3. @oleonard @gmcharlt

    Fix for Bug 4436, reserve should say 'hold'

    oleonard authored gmcharlt committed
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  4. @gcollum @gmcharlt

    Bug 2889: Added zebra striping to the table in dictionary.tmpl.

    gcollum authored gmcharlt committed
    Also fixed a couple of minor XHTML errors.
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  5. @colinsc @gmcharlt

    Bug 2889 Remove toggle in boraccount display

    colinsc authored gmcharlt committed
    Also remove the reverse column if no contents to be displayed
    ( otherwise looks like a markup error )
    Rationalize the main loop now toggle not required
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  6. @gmcharlt

    followup - update SCO to recognize ITEMNOTSAMEBRANCH

    gmcharlt authored
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  7. @gmcharlt

    on checkout ask for confirmation if borrower from different branch

    Michael Hafen authored gmcharlt committed
    With IndependantBranches on check that the borrower is from the same branch as
    the librarian.  If not then ask for confirmation.  This check is skipped for
    SuperLibrarians.
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  8. @gmcharlt

    Fixes bug 4369: Local use does not update datelastseen

    Ian Walls authored gmcharlt committed
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  9. @gmcharlt
  10. @gmcharlt

    bug 4036, 4405: overdue and fine day block improvements

    gmcharlt authored
    * Adopted wording suggested by Kyle Hall for the
      USERBLOCKEDREMAINING and USERBLOCKEDOVERDUE circulation blocks
    * Updated IsMemberBlocked so that if a patron has accrued
      fine days, that will be tested for first before testing
      to see if the patron has current overdue items; this solves
      a problem introduced in the patch series for bug 4505 where
      accrued fine days would be ignored if (a) the patron has
      current overdue items but (b) the library has chosen to
      set the OverduesBlockCirc syspref to noblock.
    * Now correctly assigns the USERBLOCKEDREMAINING and USERBLOCKEDOVERDUE
      blocks; prior to this patch, they had been swapped.
    
    FIXME: IsMemberBlock ought to be split into two functions
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  11. @gmcharlt

    bug 4429: do not include items due today in overdue count

    gmcharlt authored
    Use curdate() instead of now() in GetMemberIssuesAndFines.
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  12. @gmcharlt

    bug 4036: do not count item overdue if it is due today

    gmcharlt authored
    * use curdate() instead of now() to test whether item is overdue
    * enhanced POD of IsMemberBlocked
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  13. @gmcharlt

    bug 4396: remove reerences to bi_notforloan

    gmcharlt authored
    These were causing the OPAC details place hold button to disappear
    in circumstances where a bib-level item type was set to a non-loanable
    item type even when item-level_itypes was on.
    
    This change does mean that if item-level_itypes is not turned on,
    the hold button will now appear for bibs whose bib-level item type
    has its not-for-loan flag set; however, if this is a problem, a
    better long-term fix would be to use CanBookBeReserved() instead.
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  14. @gmcharlt

    simplify logic for displaying item status

    gmcharlt authored
    Flatten the tmpl_if tree for determining the item status
    to display and tweaked the order in which statuses are checked to
    
    1. (circ reality) item on loan
    2. (circ reality) item in transit
    3. (circ reality) item wating at hold shelf
    4. (item status that makes circ impossible) item withdrawn
    5. (item status that makes circ impossible) item lost
    6. (policy that implies no circ but in-house use possible) item not-for-loan per item
    7. (policy that implies no circ but in-house use possible) item not-for-loan per item type
    8  (item status that *might* affect circ) damaged
    8. (fallback) item available
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  15. @gmcharlt

    bug 4396: clarify return of itemtype-level notforloan flag

    gmcharlt authored
    * GetItemsInfo now includes a notforloan_per_itemtype key
      with the value of the item type's notforloan setting, correctly
      set based on the value of the item-level_itypes syspref
    * Adjusted OPAC details item status display to use that
      notforloan_per_itemtype key
    
    NOTE: one of the assumptions of item-level_itypes is that
          you can have either bib-level item types or item-level
          item types, but not both in the same database.  In particular,
          it does not establish a hierarchy where Koha checks the
          item-level itemtype first, then the bib-level.
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  16. @gmcharlt

    bug 4396: create new OPAC template include for item status

    gmcharlt authored
    As part of preparing to work on bug 4396 (item level item types not
    working correctly when biblioitem-level item type is not for loan),
    moving the item status template logic to a separate include to make
    it easier to work with.
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  17. @ranginui @gmcharlt

    Adding another developer to the history

    ranginui authored gmcharlt committed
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  18. @gcollum @gmcharlt

    Bug 4432: Fixes XHTML in serials-edit.tmpl.

    gcollum authored gmcharlt committed
    Replaces a reference to an undefined variable, num, with a defined variable to create unique ids.
    
    Also adds zebra striping to the table.
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  19. @gcollum @gmcharlt

    Bug 4200: Fixes adding a member to a routing list after filtering res…

    gcollum authored gmcharlt committed
    …ults.
    
    Adds a hidden field for subscriptionid to the filter form.
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  20. @gcollum @gmcharlt

    Bug 3883: Fixes blank line in routing list.

    gcollum authored gmcharlt committed
    The blank line was being caused by the SELECT statement in the getroutinglist fuction of C4::Serials.  The LEFT join in the select statement was creating a single row result of NULL.  Changed the LEFT join to an INNER join.
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Commits on May 1, 2010
  1. @gmcharlt

    bug 4505 followup - template changes

    gmcharlt authored
    * fix syntax error
    * adjust wording - "patron" instead of "borrower"
    * handle case where overdue items should require
      confirmation of loan by operator
    * fix typo in system preference template
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  2. @gmcharlt

    bug 4505 followup: fixes to database update

    gmcharlt authored
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  3. @gmcharlt

    bug 4405 followup - fix typo

    gmcharlt authored
    As much as circ staff may want to block circulation to
    over-rude patrons, Koha probably shouldn't be trying to make
    that determination on its own. :)
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  4. @ranginui @gmcharlt

    Bug 4405 - Overdues block check out

    ranginui authored gmcharlt committed
    [Documentation note by RM:
    
    This patch adds a new system preference, OverduesBlockCirc,
    that can take one of three values:
    
      - noblock:      checkouts permitted even if patrons
                      have overdue items (default)
      - confirmation: circ operator asked to confirm checkout
      - block:        checkouts to patrons who have overdue
                      items are forbidden
    
    ]
    
    Squashed commit of the following:
    
    commit 6a1f66e0686a14d8a89abfc3fe5978dabd0b7af7
    Author: Chris Cormack <chrisc@catalyst.net.nz>
    Date:   Mon Apr 26 10:27:39 2010 +1200
    
        Tidy up ready to send patch
    
    commit 4d1398df18dcce4fd888cf17a0e2955fdf6ee1e4
    Author: Chris Cormack <chrisc@catalyst.net.nz>
    Date:   Mon Apr 26 10:26:15 2010 +1200
    
        Bug 4405 - tidy up
    
    commit 3daeb71bc6b690e18dda96aa3c767c2bb0521038
    Author: Chris Cormack <chrisc@catalyst.net.nz>
    Date:   Mon Apr 26 10:02:04 2010 +1200
    
        Bug 4405 - Overdues block checkout
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  5. @laurenthdl @gmcharlt

    (bug #4319) allow reserves on waiting items

    laurenthdl authored gmcharlt committed
    This add a function to check the reserve status, and add a check in IsAvailableForItemLevelRequest() to allow request on items that are waiting
    
    Conflicts solved:
    
    	C4/Reserves.pm
    
    Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  6. @gmcharlt

    fix DBrev 132

    gmcharlt authored
    * renamed index; there was already an index named 'lang' on language_description
    * removed reference to ersataz DB rev number
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  7. @laurenthdl @gmcharlt

    Performance enhancing DBRev:132

    laurenthdl authored gmcharlt committed
    Adding an index on language_descriptions table in order to boost searches
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  8. @PaulPoulain @gmcharlt

    MT3228 : trailing space block search

    PaulPoulain authored gmcharlt committed
    Removing trailing searchs befor operands which block searches
    
    Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  9. @gmcharlt

    fix description of DB rev 131

    gmcharlt authored
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  10. @laurenthdl @gmcharlt

    Transport_type print missing

    laurenthdl authored gmcharlt committed
    This type is quite important for all the print notices
    
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  11. @laurenthdl @gmcharlt

    MT3346 : overdue_notices

    laurenthdl authored gmcharlt committed
    -csv was not working as advertised.
    This feature is now working as it is forecast
    
    Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
    Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Something went wrong with that request. Please try again.