11 12 pt1667219 4 08
- fixed wrong way to get superlibrarian permission - fixed namespace problem in Circulation.pm calling ModReserve
11 10 pt16468403 4 08
and we do a MarkLostItemsReturned upon a Lost+Charge on issued item, and we have to get the branch for looking up which issuing rule to use
Pt16371557 4 08
Directories such as misc/ C4/ Koha/ and so on should not be accessible via URI. This patch uses middleware to exclude access to shell-only areas. DEPENDENCIES: * ADDS: Plack::Middleware::Status
DEPENDENCIES: * ADDS: Plack::Middleware::Header
Pt16029551 4 08
If, as in the case of a newly deleted title, an OPAC search result list includes a title that no longer exists, the COinS creator would die from accessing an unchecked return value. This patch explicitly croaks in that case and places catch()es within the caller to emit a simple warn instead of dying.
11 02 pt16152385 4 08
…eeds to be done in so many places
10 10 pt14149993 4 08
- suppress Perl warning of uninit var in numeric comparison of $lasttime when there isn't any (maybe we logged out properly?) - Plack eval()'s expect clean exits, so installer.pl was backwards and never reached login page after Web installation step 3, cannot exit nonzero
…r fixes: - fix undef Perl warning in mapping in fines.pl - fix overdue from datedue calculation, was using object instead of ISO date from issues - finally finished work on refund owed for backdate checkin resulting in downward adjustment of fine - converted Yes|No option to Continue prompt: Remove from patron's Lost Items - retested and fixed some lost prompts +notissued/issued, +hold/nohold, &c.
notissued, noholds. Tested against other cases: case 1) lostNcharge+nohold+notissued 1.a. checkin at A - OK 1.b. checkin at B - OK 1.b.ii. had previous transfer - OK case 2) lostMissing+nothold+notissued 2.a. checkin at A - OK, click <OK> and form will now submit 2.b. checkin at B 2.b.i. no prior transfer - OK 2.b.ii. have prior transfer - OK
- handle case: item already waiting at pickup branch, checkin at pickup branch; relax previous assumption that item is permanent collection (not always true) - allow ignore hold upon checkin at pickup library and not yet waiting (don't automatically set hold to waiting in AddReturn())
- <Confirm and transfer> button was dead - patron details: On Holds tab was displaying both intransit and waiting - put intransit and add to branchtransfers when notlost, notissued * TODO: fault tolerance for intransit but no entry in branchtransfers
Pt15591737 4 08
Pt16042719 4 08
C4::Koha::GetAuthorisedValue had been improperly refactored to use the CHI cache object handle rather than the computed cache contents. This of course resulted in all calls to GetAuthorisedValue to return undef.