Permalink
Commits on Sep 22, 2011
  1. [delivers #18667851] Force C4::Context->preference() to return scalar

    If a pref is not registered, preference() returns a context-dependent
    value.  Lots of code, in particular in C4::Auth::get_user_and_template,
    calls preference() from a list context, and that can cause things like
    setting values in a hash to have empty lists as values, which ends up
    being a non-value, and completely rearranging the var/val relationships
    that ought to be set.
    ctfliblime committed Sep 22, 2011
Commits on Sep 21, 2011
  1. PT16549719: Fatal error saving default item settings

    Database schema needed to be restructured. New column session_defaults_id
    was added and made the primary key.
    dlbptfs committed Sep 21, 2011
  2. [LLK #17425237] one more place accounttype FU turns into F upon checkin:

    was not catching case of cron ran on same day as checkin
    ha committed Sep 21, 2011
Commits on Sep 19, 2011
  1. Micro release: 4.8.21

    ctfliblime committed Sep 19, 2011
  2. PT17763203: Patron barcode on OPAC login using significant digits only

    Minor typo in a hash key.
    dlbptfs committed with ctfliblime Sep 8, 2011
  3. [#11414367] mandatory fields weren't checked in MARC bib editing:

    YAHOO.widget.Button didn't call right function, other minor fixes
    was to make sure tag and subfield were both checked, since one
    was 'tag_mandatory' and the other was 'mandatory'.  Also added *.
    Display and JS check should now work for any framework.
    hgq committed with ctfliblime Sep 7, 2011
  4. PT17016201: Using Suspend All button in OPAC...

    Appears the smart matching was not correctly being evaluated as
    'W'aiting and 'T'ransit items were still being suspended.  The
    croak error is also now being caught by Try::Tiny.
    dlbptfs committed with ctfliblime Sep 8, 2011
  5. Merge pull request #159 from hgq/13_03_pt17425127_4_08

    13 03 pt17425127 4 08
    ctfliblime committed Sep 19, 2011
  6. [#18149087] (cleanup) Calling exit() from core modules

    Not that these two exit() calls were reachable, anyway, since an
    unconditional return is called just prior to each of them, but
    exit() should never be called from a module. It's safe to call
    it from a .pl script, but calling it from within a .pm causes
    the Plack engine itself to exit, which is bad news.
    ctfliblime committed Sep 19, 2011
  7. Merge pull request #185 from hgq/15_06_pt18149087_4_08

    15 06 pt18149087 4 08
    ctfliblime committed Sep 19, 2011
  8. Merge pull request #183 from hgq/15_04_pt14999551_4_08

    15 04 pt14999551 4 08
    ctfliblime committed Sep 19, 2011
  9. Merge pull request #180 from hgq/15_03_pt17119619_4_08

    15 03 pt17119619 4 08
    ctfliblime committed Sep 19, 2011
  10. Merge pull request #176 from ctfliblime/PT13645205-4_08

    Pt13645205 4 08
    ctfliblime committed Sep 19, 2011
  11. Merge pull request #172 from hgq/14_05_pt17944127_4_08

    14 05 pt17944127 4 08
    ctfliblime committed Sep 19, 2011
  12. Merge pull request #169 from hgq/14_04_pt17807355_4_08

    14 04 pt17807355 4 08
    ctfliblime committed Sep 19, 2011
Commits on Sep 14, 2011
  1. LLK #14999551: bug was item was lost and found at checkin, had no

    holds, needed to be transferred back to Home branch but no prompt
    for transfer, only the lost+link to patron patron.  fix was to
    check for both transfer and needstransfer, which are ambiguous
    distinctions anyway.  Also tested case when no patron is attached
    but item was lost and found and needed transfer to item Home.
    hgq committed Sep 14, 2011
Commits on Sep 12, 2011
  1. LLK #17119619: remove from tmp_holdsqueue upon mod item to holdsfille…

    …d=0:
    
    this is now done in 4 places: when the cronjob runs, on the bib's Items
    page for the item's otherstatus, on the add/edit item page, and batch
    item modify
    NOTE: outstanding is warning prompts/confirmations not implemented
    hgq committed Sep 12, 2011
Commits on Sep 7, 2011
  1. PT16314875: SIP2 renew response

    The ok field (pos3) in the SIP2 renewal response message (30) was a
    little ambiguous despite the renewal_ok field (pos4) being less so.
    
    In addition, a renewal denial because of patron conditions is now
    better handled.  It was previously allowing attempted work on an
    undefined object.
    dlbptfs committed with ctfliblime Aug 3, 2011
  2. [delivers #13645205] Try to maintain valid location with cart-to-shel…

    …f enabled
    
    If items.permanent_location is NULL/empty, save the
    contents of items.location into it before setting
    current location to shelf.
    ctfliblime committed Sep 7, 2011
  3. [#17944127] semicolon in migrated data description field of accountlines

    broke form post.  actually, any bizarre character.  solution: escape with
    javascript before submitting the form.  later on, fetch the accountline
    straight from the database, since we have to loop through it anyway to
    draw the refund tab.  There was a Firefox bug with hitting the back
    button that encoded stuff twice.  We just toss the form info of the
    accountline and use the database instead.
    hgq committed Sep 7, 2011
Commits on Sep 6, 2011
Commits on Sep 2, 2011
  1. Micro release: 4.8.20

    ctfliblime committed Sep 2, 2011
  2. PT16591205: PTFS version of Batch Edit Items does not work

    Additional variable scoping issues manifested in the Plack environment.
    dlbptfs committed with ctfliblime Aug 30, 2011
  3. PT16590983: Error using community batch edit on CLIC sandbox

    Error was being thrown on a close STDERR.  Removed this line of code.
    I suspect this was Plack related although I not necessarily sure why.
    dlbptfs committed with ctfliblime Sep 1, 2011
  4. Revert "PT15650379: Cannot Save Changes to Leader"

    This reverts commit eb7bd6c.
    
    The change as implemented breaks the leader, causing encoding problems.
    ctfliblime committed Sep 2, 2011
Commits on Aug 30, 2011
  1. Micro release: 4.8.19

    ctfliblime committed Aug 30, 2011
  2. Bad practice to export class methods

    Also clean up useless debugging noise
    ctfliblime committed Aug 30, 2011
Commits on Aug 29, 2011
  1. Micro release: 4.8.18

    ctfliblime committed Aug 29, 2011
  2. Merge pull request #154 from hgq/13_01_pt14554159_4_08

    13 01 pt14554159 4 08
    ctfliblime committed Aug 29, 2011
  3. Merge pull request #156 from hgq/13_02_pt16905729_4_08

    13 02 pt16905729 4 08
    ctfliblime committed Aug 29, 2011
  4. [delivers #17078993] Clean up caching of MARC framework maps

    The meat of this is the changes to C4/Biblio.pm, using a safe
    caching function instead of storing it in a package global. The
    changes to C4/Items.pm are preventative cleanup to keep this
    variable from being set at some point in the future.
    ctfliblime committed Aug 29, 2011
  5. [#17425237] wasn't able to pay upon returned overdue item when

    syspref EnableOverdueAccruedAmount was ON: pass to UpdateFine()
    the new accounttype, from 'FU' to 'F' so patron can pay on it
    hgq committed Aug 29, 2011