Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the musical unicode character ♭, ♮ and ♯ to "de-de-comp8.ctb" #685

Open
DrSooom opened this Issue Jan 12, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@DrSooom
Copy link

DrSooom commented Jan 12, 2019

Quote from my comment on NVDA issue #9138:

Well, and in the "de-de-comp8.ctb" I also added the following as well:

sign \x266d 12
sign \x266e 2356
sign \x266f 3456

[Update 2019-01-12-2353+0100] ♭ is equal to b, ♮ to = and ♯ to #. [/Update]

Maybe it's better to add these unicode characters themselves behind those three lines as a comment too. And no, I'm not sure if this is a standard, but as those three characters are also replace quite often with b, = and #, I personally see no reason why we should not implement the same in the 8-dot German braille table. But in the end it's your decision, not mine. As you might know from my earlier posts I'm editing and adding characters in this table by my own as I want – no matter it's a standard or not.

See also PR #677 and my comment on NVDA issue #1717.

@leonardder

This comment has been minimized.

Copy link
Contributor

leonardder commented Jan 14, 2019

How are these characters chosen?

I think we should avoid adding symbols to a table without evidence of their use in the wild.

@DrSooom

This comment has been minimized.

Copy link
Author

DrSooom commented Jan 15, 2019

♭ is equal to b, ♮ to = and ♯ to #. See also how the key is defined in the ABC notation. So these three replacements are also used in environmental where unicode characters can't be used.

@bertfrees

This comment has been minimized.

Copy link
Member

bertfrees commented Feb 25, 2019

Is there a PR for this issue?

@egli

This comment has been minimized.

Copy link
Member

egli commented Feb 25, 2019

There was only #677 that I can think of. But afaik the characters mentioned in this issue aren't solved in #677.

So in other words afaik there is no PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.