New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters should be separated #85

Open
9il opened this Issue Nov 16, 2016 · 7 comments

Comments

Projects
None yet
2 participants
@9il

This comment has been minimized.

Show comment
Hide comment
@9il

9il Nov 16, 2016

Member

The idea of separable filter is to perform one direction and then another one.
We also need to add image cache-friendly blocking. Image should be splitted into blocks 15 KBs each. Then for each block we apply H and G filter parts.
In addition we may remove Yes.vectorized and Yes.fastmath (needs benchmark).

Member

9il commented Nov 16, 2016

The idea of separable filter is to perform one direction and then another one.
We also need to add image cache-friendly blocking. Image should be splitted into blocks 15 KBs each. Then for each block we apply H and G filter parts.
In addition we may remove Yes.vectorized and Yes.fastmath (needs benchmark).

@9il

This comment has been minimized.

Show comment
Hide comment
@9il

9il Nov 16, 2016

Member

see also #86

Member

9il commented Nov 16, 2016

see also #86

@ljubobratovicrelja

This comment has been minimized.

Show comment
Hide comment
@ljubobratovicrelja

ljubobratovicrelja Nov 16, 2016

Member

We also need to add image cache-friendly blocking. Image should be splitted into blocks 15 KBs each

This is something I've been meaning to talk to you about for some time now. Halide language may come as nice reference, for cache friendliness:
http://halide-lang.org/

Awesome let's do it. Do you have a proposition how do we do this? I could come up with something, but I'd really like go hear what you think. Do we need (or want) to redesign the base filtering API?

Member

ljubobratovicrelja commented Nov 16, 2016

We also need to add image cache-friendly blocking. Image should be splitted into blocks 15 KBs each

This is something I've been meaning to talk to you about for some time now. Halide language may come as nice reference, for cache friendliness:
http://halide-lang.org/

Awesome let's do it. Do you have a proposition how do we do this? I could come up with something, but I'd really like go hear what you think. Do we need (or want) to redesign the base filtering API?

@9il

This comment has been minimized.

Show comment
Hide comment
@9il

9il Nov 16, 2016

Member

Halide language may come as nice reference, for cache friendliness:
http://halide-lang.org/

Awesome! We can implement Halide as library solution in Dlang :-)

Member

9il commented Nov 16, 2016

Halide language may come as nice reference, for cache friendliness:
http://halide-lang.org/

Awesome! We can implement Halide as library solution in Dlang :-)

@ljubobratovicrelja

This comment has been minimized.

Show comment
Hide comment
@ljubobratovicrelja

ljubobratovicrelja Nov 16, 2016

Member

We can implement Halide as library solution in Dlang

What do you mean by this? Using halide inside D?

Member

ljubobratovicrelja commented Nov 16, 2016

We can implement Halide as library solution in Dlang

What do you mean by this? Using halide inside D?

@9il

This comment has been minimized.

Show comment
Hide comment
@9il

9il Nov 16, 2016

Member

What do you mean by this? Using halide inside D?

No, we can implement its functionality as an ndslice module

Member

9il commented Nov 16, 2016

What do you mean by this? Using halide inside D?

No, we can implement its functionality as an ndslice module

@ljubobratovicrelja

This comment has been minimized.

Show comment
Hide comment
@ljubobratovicrelja

ljubobratovicrelja Nov 16, 2016

Member

we can implement its functionality as ndslice module

YES - This is something I've been thinking about for a long time - we should definitely do this!

Member

ljubobratovicrelja commented Nov 16, 2016

we can implement its functionality as ndslice module

YES - This is something I've been thinking about for a long time - we should definitely do this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment