Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add RTC definitions for "v2" RTC modules. #68

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Member

karlp commented Nov 18, 2012

F1 already has an existing RTC implementation and headers, but it is a
radically different peripheral. F2,F3,F4, F0 and L1 all have a "v2" RTC
module, using BCD time/date registers and providing alarms.

This commit provides a "dispatch" header for the appropriate family,
as well as providing most of the register bit definitions.
(Calibration and sub second registers have been skipped for now)

No examples yet for L1 or F4.

@karlp karlp Add RTC definitions for "v2" RTC modules.
F1 already has an existing RTC implementation and headers, but it is a
radically different peripheral. F2,F3,F4, F0 and L1 all have a "v2" RTC
module, using BCD time/date registers and providing alarms.

This commit provides a "dispatch" header for the appropriate family,
as well as providing most of the register bit definitions.
(Calibration and sub second registers have been skipped for now)

No examples yet for L1 or F4.
c12fdb1

tdaede commented on c12fdb1 Dec 1, 2012

Does a dispatch header really make sense, considering that the peripherals are completely different?

Owner

karlp replied Dec 3, 2012

tdaede: well, they're virtually identical for f4, l1, f0 and f3. f2 is a subset, but still has the full calendar. it's really F1 that doesn't belong. I'm open to suggestions on whether it's better or worse to have the dispatch header in that case.

More importantly, there are errors in this pull. I'm going to hold off until I have a working example for this.

Member

karlp commented Dec 3, 2012

I would still appreciate any comments on this, but this code should NOT be pulled as is!

@karlp karlp closed this Dec 3, 2012

Contributor

ksarkies commented Dec 3, 2012

I tend to be in favour of the dispatch header. It provides a common point for finding the header for any peripheral regardless of the family and in the long run will make the business of navigating around the library just a bit easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment