Fix vmware vm uuid parsing and add DeleteFrom and DetachFrom

[harsh-px]

Signed-off-by: Harsh Desai harsh@portworx.com

What this PR does / why we need it:

1. User doesn't need to give vsphere vmuuid from environment. It's optional.
2. Add DeleteFrom and DetachFrom API's to detach and delete if invoked from a different node

[lpabon]

FYI: title has add DeleteFrom and DeleteFrom

[lpabon]

curious why this change is needed?

[harsh-px]

VMUUID is required to be fetched from the env variableVSPHERE_VM_UUID only if one is running unit tests for dev.

When running in a real vSphere environment, Portworx (porx) will fetch this from a cloudprovider providerID field that the vmware cloud provider in k8s populates in the node object. For e.g

- apiVersion: v1
  kind: Node
  metadata:
    creationTimestamp: 2018-08-13T03:46:12Z
  spec:
    externalID: 421076c2-e509-7897-e64f-84b0bff79cbe
    providerID: vsphere://421076c2-e509-7897-e64f-84b0bff79cbe

So we don't need the env variable.

And in a non-k8s environment, this can be fetched from a /sys/fs file where vmware puts the vm uuid.

[sangleganesh]

@harsh-px just for my info, is there a reason this code is a part of libopenstorage ?

[harsh-px]

@harsh-px just for my info, is there a reason this code is a part of libopenstorage ?

This is the storageops interface ASG/cloud drive code in porx (AWS, GCE, vSphere) uses. For e.g https://github.com/portworx/porx/blob/master/storage/hal/provider/aws/aws_storage.go#L50 is where aws uses it.

[adityadani]

the changes look good.
Please add a UT esp. for DetachFrom for completeness.

[sangleganesh]

@harsh-px iirc the reason storage ops of AWS was put in libopenstorage was to have AWS volume driver code reuse the storage ops. gke/vmware don't have that dependency (does not have volume driver implementation for osd). is there any interface/implementation required for osd itself from either gke/vmware ?

[harsh-px]

Please add a UT esp. for DetachFrom for completeness.

@adityadani added

@harsh-px iirc the reason storage ops of AWS was put in libopenstorage was to have AWS volume driver code reuse the storage ops. gke/vmware don't have that dependency (does not have volume driver implementation for osd). is there any interface/implementation required for osd itself from either gke/vmware ?

Nothing in osd is using gke/vmware. Currently it's only porx. Project rico in libopenstorage was going to use all of these storage ops (https://github.com/libopenstorage/rico/tree/master/pkg/cloudprovider).