From 03ec8227cda40839246028b64bc618d825e19444 Mon Sep 17 00:00:00 2001 From: Adam Krpan Date: Wed, 19 Jul 2023 01:28:01 +0000 Subject: [PATCH] PWX-32177: Removes unnecessary permissions from diag collector pods --- pkg/controller/portworxdiag/pod.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/pkg/controller/portworxdiag/pod.go b/pkg/controller/portworxdiag/pod.go index 51ece4f5a..717b06d4d 100644 --- a/pkg/controller/portworxdiag/pod.go +++ b/pkg/controller/portworxdiag/pod.go @@ -46,7 +46,6 @@ func volumeMounts() []v1.VolumeMount { } func makeDiagPodTemplate(cluster *corev1.StorageCluster, diag *portworxv1.PortworxDiag, ns string, nodeName string, nodeID string) (*v1.PodTemplateSpec, error) { - svcLinks := true terminationGP := int64(10) privileged := true @@ -79,11 +78,8 @@ func makeDiagPodTemplate(cluster *corev1.StorageCluster, diag *portworxv1.Portwo }, Spec: v1.PodSpec{ NodeName: nodeName, - HostPID: true, // We *do* need this - HostNetwork: true, // Do we need this?: https://portworx.atlassian.net/browse/PWX-32177 - RestartPolicy: v1.RestartPolicyOnFailure, // - DNSPolicy: v1.DNSClusterFirst, // Do we need this? https://portworx.atlassian.net/browse/PWX-32177 - EnableServiceLinks: &svcLinks, // Do we need this? https://portworx.atlassian.net/browse/PWX-32177 + HostPID: true, + RestartPolicy: v1.RestartPolicyOnFailure, ServiceAccountName: pxutil.PortworxServiceAccountName(cluster), TerminationGracePeriodSeconds: &terminationGP, Volumes: volumes(),