Skip to content

PB-4245 :: Restrict backup of "kube-system" ns#1506

Merged
vikasit12 merged 1 commit into
masterfrom
PB-4245
Sep 20, 2023
Merged

PB-4245 :: Restrict backup of "kube-system" ns#1506
vikasit12 merged 1 commit into
masterfrom
PB-4245

Conversation

@vikasit12
Copy link
Copy Markdown
Contributor

  • Restrict backup of "kube-system" in case of all namespaces i.e. *
  • Restrict backup of "kube-system" in case of label-selector
  • Allow backup of "kube-system" in case API is specifically passing it i.e. namsespace=kube-system in API call

What type of PR is this?

feature

What this PR does / why we need it:
This PR restricts kube-system ns backup in below scenarios.

  • Restrict backup of "kube-system" in case of all namespaces i.e. *
  • Restrict backup of "kube-system" in case of label-selector

Does this PR change a user-facing CRD or CLI?:

no

Is a release note needed?:

yes
Issue: #PB-4245
User Impact: User will not be able to backup kube-system namespace if tried with label-selector or all namespace
Resolution: If user wants to backup kube-system namespace the one needs to pass it specifically as namsespace=kube-system in API calls

Does this change need to be cherry-picked to a release branch?:

yes, 23.9

Testing Screenshot

Before fix

Screenshot 2023-09-14 at 8 16 16 PM
Screenshot 2023-09-14 at 8 17 46 PM
Screenshot 2023-09-14 at 8 24 21 PM
Screenshot 2023-09-14 at 8 25 20 PM
Screenshot 2023-09-14 at 8 26 00 PM
Screenshot 2023-09-14 at 8 58 30 PM
Screenshot 2023-09-14 at 8 58 55 PM
Screenshot 2023-09-14 at 8 59 28 PM

After Fix

Screenshot 2023-09-15 at 1 30 56 PM
Screenshot 2023-09-15 at 1 31 55 PM
Screenshot 2023-09-15 at 1 32 36 PM
Screenshot 2023-09-15 at 1 34 22 PM
Screenshot 2023-09-15 at 1 35 45 PM
Screenshot 2023-09-15 at 1 36 05 PM
Screenshot 2023-09-15 at 6 01 43 PM
Screenshot 2023-09-15 at 6 02 14 PM
Screenshot 2023-09-15 at 6 02 34 PM

@cnbu-jenkins
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@vikasit12 vikasit12 force-pushed the PB-4245 branch 2 times, most recently from a933492 to 87adc03 Compare September 15, 2023 14:06
- Restrict backup of "kube-system" in case of all namespaces i.e. *
- Restrict backup of "kube-system" in case of label-selector
- Allow backup of "kube-system" in case API is specifically passing it
        i.e. namsespace=kube-system in API call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants