Add methods to clear stats #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested changes
Oct 31, 2019
1. Handle `registered` inside the main loop. This way we can avoid atomics. 2. Don't start calculating bandwidth for newly active meters until they've been active for a round. This: 1. Ensures we only write to the snapshot from within the main loop. 2. Gives us a better estimated bandwidth usage.
1. The last update is when we last saw activity. We don't need to update it when we reset the meter. 2. Defer isn't _quite_ as fast as it could be.
Stebalien
reviewed
Nov 1, 2019
|
@kpp I needed to so some experimentation so it was simpler to make changes directly than to leave comments in a review. Do my changes LGTY? |
|
Your solution looks even better than mine. LGTM |
7 tasks
|
Unfortunately your solution does not pass tests from go-libp2p-core/metrics. See https://github.com/libp2p/go-libp2p-core/pull/71/files and play with it. Whereas mine works fine. Don't forget about |
|
The issue is that this version starts tracking bandwidth one second later. I'll update those tests. |
The previous attempt actually make the problem worse: 1. It didn't update the "last update" time. 2. It updated the accumulator but then didn't set the total. That meant that the _next_ update would count the bandwidth from two time periods. This change also reverts the changes to the test (the test was right, the code was wrong).
|
Actually, the issue is that I implemented this wrong, misdiagnosed why the test was failing, then broke the tests 🤦♂️. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.