Skip to content
This repository has been archived by the owner. It is now read-only.

Trim frequency should never be lower than the grace period. #51

Closed
Stebalien opened this issue Jul 30, 2019 · 2 comments · Fixed by #52
Closed

Trim frequency should never be lower than the grace period. #51

Stebalien opened this issue Jul 30, 2019 · 2 comments · Fixed by #52
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

Stebalien commented Jul 30, 2019

It's currently a fixed one minute. It should probably be something like graceperiod/2.
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Jul 30, 2019
@Stebalien
Copy link
Member Author

Stebalien commented Jul 30, 2019 •
edited

Actually, it looks like we also trim connections when we receive new ones so this issue shouldn't be all that noticeable.

No we don't.

@Stebalien
Copy link
Member Author

Stebalien commented Jul 30, 2019

cc @swedneck

Stebalien added a commit that referenced this issue Jul 30, 2019
@Stebalien
fix: trim connections every gracePeriod/2
38d3e68 
We're still rate-limited to once every 10 seconds. However, this means that
setting the grace period to something below one minute actually _does_ something
useful.

fixes #51
@Stebalien Stebalien mentioned this issue Jul 30, 2019
Merged
Stebalien added a commit that referenced this issue Jul 30, 2019
@Stebalien
fix: trim connections every gracePeriod/2
ee00742 
We're still rate-limited to once every 10 seconds. However, this means that
setting the grace period to something below one minute actually _does_ something
useful.

fixes #51
Stebalien added a commit that referenced this issue Jul 30, 2019
@Stebalien
fix: trim connections every gracePeriod/2
70d33c1 
We're still rate-limited to once every 10 seconds. However, this means that
setting the grace period to something below one minute actually _does_ something
useful.

fixes #51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: trim connections every gracePeriod/2 libp2p/go-libp2p-connmgr
1 participant
@Stebalien