Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed Provider records for the DHT #559

Open
aarshkshah1992 opened this issue Apr 6, 2020 · 3 comments
Open

Signed Provider records for the DHT #559

aarshkshah1992 opened this issue Apr 6, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@aarshkshah1992
Copy link
Contributor

aarshkshah1992 commented Apr 6, 2020

We need to have signed provider records in the DHT so receivers can verify if the records were indeed advertised by peers marked as the providers on the records. However, this depends on ipfs/kubo#6916.

@jacobheun @Stebalien

  1. Can we add this to Working Kademlia for 0.6 ?
  2. What's the status on making Ed25519 the default signing ?
@aarshkshah1992 aarshkshah1992 self-assigned this Apr 6, 2020
@jacobheun jacobheun added this to the go-ipfs 0.6 milestone Apr 6, 2020
@jacobheun
Copy link

jacobheun commented Apr 6, 2020

Can we add this to Working Kademlia for 0.6?

That is the goal, I've duplicated the 0.6 milestone here and added it for tracking.

What's the status on making Ed25519 the default signing?

This is planned for IPFS 0.6, ed25519 will be used by default.

@mikeal
Copy link
Member

mikeal commented Jul 27, 2020

One more thing I’d like to see make it into the record is the CID prefix. It’s only two varints, but it makes the record a lot more valuable as it allows us to decode the data into an actual data structure.

Since it’s in the record it would end up being backwards compatible and could even be optional (although I’d like to see us include it by default).

@aschmahmann
Copy link
Contributor

aschmahmann commented Jul 27, 2020

I’d like to see us include it by default

👍 especially for people that want to use graphsync instead of bitswap having the codec information is very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants