This repository has been archived by the owner on May 26, 2022. It is now read-only.
Refactor dial worker loop into an object and fix bug #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mudler
added a commit
to mudler/edgevpn
that referenced
this pull request
Feb 21, 2022
pinpoint to libp2p/go-libp2p-swarm#315 in order to collect feedback for libp2p/go-libp2p-swarm#314
mudler
added a commit
to mudler/edgevpn
that referenced
this pull request
Feb 21, 2022
pinpoint to libp2p/go-libp2p-swarm#315 in order to collect feedback for libp2p/go-libp2p-swarm#314
mudler
added a commit
to mudler/edgevpn
that referenced
this pull request
Feb 21, 2022
pinpoint to libp2p/go-libp2p-swarm#315 in order to collect feedback for libp2p/go-libp2p-swarm#314
mudler
added a commit
to mudler/edgevpn
that referenced
this pull request
Feb 21, 2022
pinpoint to libp2p/go-libp2p-swarm#315 in order to collect feedback for libp2p/go-libp2p-swarm#314
It turns out it is not actually necessary if the limiter short-circuits. Point being is that if the request channel has been closed, there is no active dial any more, at which point we might as well consider it done. This fixes the goroutine leak.
vyzo
force-pushed
the
fix/dial-worker
branch
from
64d8f91
to
d85a395
Compare
|
squashed some commits to clean up history. |
marten-seemann
approved these changes
Feb 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dial worker loop has been refactored into an object to aid testability.
And more importantly, a goroutine leak is fixed by dropping the unnecessary active dial tracking logic.
Closes #314