Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace btcd with one without chaincfg/chainhash #1524

Closed
wants to merge 1 commit into from
Closed

chore: replace btcd with one without chaincfg/chainhash #1524

wants to merge 1 commit into from

Conversation

galargh
Copy link
Contributor

@galargh galargh commented May 24, 2022

These pass with the replace:

go mod tidy
go mod test

They removed chaincfg/chainhash in btcsuite/btcd#1851

@galargh galargh mentioned this pull request May 24, 2022
Closed
marten-seemann
marten-seemann reviewed May 24, 2022
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also work without the replace, as a normal require?

@galargh
Copy link
Contributor Author

galargh commented May 24, 2022

No, then it stops complaining about v0.22.0-beta but it starts complaining about v0.20.1-beta.

Looks like you found how to make it work though: libp2p/go-libp2p-core#252 (comment) 🎉

@marten-seemann marten-seemann mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galargh @marten-seemann